diff --git a/activemq-karaf/src/main/resources/features-core.xml b/activemq-karaf/src/main/resources/features-core.xml
index 5a1748a99c7..af3ba4631f2 100644
--- a/activemq-karaf/src/main/resources/features-core.xml
+++ b/activemq-karaf/src/main/resources/features-core.xml
@@ -40,6 +40,8 @@
mvn:org.apache.geronimo.specs/geronimo-annotation_1.3_spec/1.0
mvn:org.apache.geronimo.specs/geronimo-jta_1.1_spec/1.1.1
mvn:org.apache.commons/commons-pool2/${commons-pool2-version}
+ mvn:org.apache.commons/commons-lang3/${commons-lang3-version}
+ mvn:org.apache.commons/commons-text/${commons-text-version}
mvn:org.apache.activemq/activemq-osgi/${project.version}
diff --git a/activemq-web/pom.xml b/activemq-web/pom.xml
index 6c1f85d28a8..900b4a2c5c3 100644
--- a/activemq-web/pom.xml
+++ b/activemq-web/pom.xml
@@ -87,6 +87,11 @@
websocket-jetty-server
+
+ org.apache.commons
+ commons-text
+
+
com.rometools
diff --git a/activemq-web/src/main/java/org/apache/activemq/web/view/RssMessageRenderer.java b/activemq-web/src/main/java/org/apache/activemq/web/view/RssMessageRenderer.java
index 088a4c1926b..f05d0467833 100644
--- a/activemq-web/src/main/java/org/apache/activemq/web/view/RssMessageRenderer.java
+++ b/activemq-web/src/main/java/org/apache/activemq/web/view/RssMessageRenderer.java
@@ -49,7 +49,7 @@ public class RssMessageRenderer extends SimpleMessageRenderer {
private String feedType = "rss_2.0";
private SyndFeed feed;
private String description = "This feed is auto-generated by Apache ActiveMQ";
- private String entryContentType = "text/plain";
+ private static final String ENTRY_CONTENT_TYPE = "text/plain";
public void renderMessage(PrintWriter writer, HttpServletRequest request, HttpServletResponse response, QueueBrowser browser, Message message) throws JMSException {
SyndFeed feed = getFeed(browser, request);
@@ -79,11 +79,7 @@ public void setFeedType(String feedType) {
}
public String getEntryContentType() {
- return entryContentType;
- }
-
- public void setEntryContentType(String entryContentType) {
- this.entryContentType = entryContentType;
+ return ENTRY_CONTENT_TYPE;
}
// Implementation methods
@@ -122,7 +118,7 @@ protected SyndEntry createEntry(QueueBrowser browser, Message message, HttpServl
protected SyndContent createEntryContent(QueueBrowser browser, Message message, HttpServletRequest request) throws JMSException {
SyndContent description = new SyndContentImpl();
- description.setType(entryContentType);
+ description.setType(getEntryContentType());
if (message instanceof TextMessage) {
String text = ((TextMessage)message).getText();
diff --git a/activemq-web/src/main/java/org/apache/activemq/web/view/SimpleMessageRenderer.java b/activemq-web/src/main/java/org/apache/activemq/web/view/SimpleMessageRenderer.java
index f8165d8849a..403bffde4af 100644
--- a/activemq-web/src/main/java/org/apache/activemq/web/view/SimpleMessageRenderer.java
+++ b/activemq-web/src/main/java/org/apache/activemq/web/view/SimpleMessageRenderer.java
@@ -26,6 +26,7 @@
import jakarta.servlet.ServletException;
import jakarta.servlet.http.HttpServletRequest;
import jakarta.servlet.http.HttpServletResponse;
+import org.apache.commons.text.StringEscapeUtils;
/**
* A simple rendering of the contents of a queue appear as a list of message
@@ -35,11 +36,12 @@
*/
public class SimpleMessageRenderer implements MessageRenderer {
- private String contentType = "text/xml";
+ protected static final String DEFAULT_CONTENT_TYPE = "text/xml";
+
private int maxMessages;
public void renderMessages(HttpServletRequest request, HttpServletResponse response, QueueBrowser browser) throws IOException, JMSException, ServletException {
- // lets use XML by default
+ // XML is used by default unless a child class overrides this method
response.setContentType(getContentType());
PrintWriter writer = response.getWriter();
printHeader(writer, browser, request);
@@ -53,10 +55,10 @@ public void renderMessages(HttpServletRequest request, HttpServletResponse respo
printFooter(writer, browser, request);
}
- public void renderMessage(PrintWriter writer, HttpServletRequest request, HttpServletResponse response, QueueBrowser browser, Message message) throws JMSException, ServletException {
+ public void renderMessage(PrintWriter writer, HttpServletRequest request, HttpServletResponse response, QueueBrowser browser, Message message) throws JMSException {
// lets just write the message IDs for now
writer.print("");
}
@@ -71,25 +73,21 @@ public void setMaxMessages(int maxMessages) {
}
public String getContentType() {
- return contentType;
- }
-
- public void setContentType(String contentType) {
- this.contentType = contentType;
+ return DEFAULT_CONTENT_TYPE;
}
// Implementation methods
// -------------------------------------------------------------------------
- protected void printHeader(PrintWriter writer, QueueBrowser browser, HttpServletRequest request) throws IOException, JMSException, ServletException {
+ protected void printHeader(PrintWriter writer, QueueBrowser browser, HttpServletRequest request) throws IOException, JMSException {
writer.println("");
writer.print("");
diff --git a/assembly/src/main/descriptors/common-bin.xml b/assembly/src/main/descriptors/common-bin.xml
index 833e3f7dc66..e7aaecbe380 100644
--- a/assembly/src/main/descriptors/common-bin.xml
+++ b/assembly/src/main/descriptors/common-bin.xml
@@ -308,6 +308,10 @@
com.rometools:rome-utils
org.jdom:jdom2
+
+ org.apache.commons:commons-text
+ org.apache.commons:commons-lang3
+
org.jolokia:jolokia-core
org.jolokia:jolokia-server-core
diff --git a/pom.xml b/pom.xml
index 260f4342fa2..3ba6b26b03d 100644
--- a/pom.xml
+++ b/pom.xml
@@ -58,6 +58,8 @@
3.2.2
2.14.0
2.21.0
+ 3.20.0
+ 1.15.0
1.3.6
2.13.1
2.0.0.AM25
@@ -901,6 +903,17 @@
${commons-io-version}
+
+ org.apache.commons
+ commons-lang3
+ ${commons-lang3-version}
+
+
+ org.apache.commons
+ commons-text
+ ${commons-text-version}
+
+
com.rometools