Skip to content

Queue browse improvements in webconsole#1938

Merged
cshannon merged 2 commits intoapache:mainfrom
cshannon:queue-browse-improvements-2
Apr 17, 2026
Merged

Queue browse improvements in webconsole#1938
cshannon merged 2 commits intoapache:mainfrom
cshannon:queue-browse-improvements-2

Conversation

@cshannon
Copy link
Copy Markdown
Contributor

This change makes sure we always use the correct content type for the output based on the configured view and also escape xml content when displaying.

This version is different from #1937 because it uses our own method for XML escaping and it does not require adding new dependencies. We do use common-text as a testing only dependency just to verify correctness.

This change makes sure we always use the correct content type for the
output based on the configured view and also escape xml content when
displaying.
jbonofre
jbonofre previously approved these changes Apr 17, 2026
Copy link
Copy Markdown
Member

@jbonofre jbonofre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a couple of minor fixes to do.

Comment thread activemq-web/src/main/java/org/apache/activemq/web/util/ViewUtils.java Outdated
Comment thread activemq-web/src/main/java/org/apache/activemq/web/util/ViewUtils.java Outdated
@cshannon cshannon merged commit a240dba into apache:main Apr 17, 2026
1 of 10 checks passed
@github-project-automation github-project-automation Bot moved this from Backlog to Done in Apache ActiveMQ v6.3.0 Apr 17, 2026
@cshannon cshannon deleted the queue-browse-improvements-2 branch April 17, 2026 11:48
cshannon added a commit to cshannon/activemq that referenced this pull request Apr 17, 2026
This change makes sure we always use the correct content type for the
output based on the configured view and also escape xml content when
displaying.

(cherry picked from commit a240dba)
cshannon added a commit to cshannon/activemq that referenced this pull request Apr 17, 2026
This change makes sure we always use the correct content type for the
output based on the configured view and also escape xml content when
displaying.

(cherry picked from commit a240dba)
cshannon added a commit to cshannon/activemq that referenced this pull request Apr 17, 2026
This change makes sure we always use the correct content type for the
output based on the configured view and also escape xml content when
displaying.

(cherry picked from commit a240dba)
cshannon added a commit to cshannon/activemq that referenced this pull request Apr 17, 2026
This change makes sure we always use the correct content type for the
output based on the configured view and also escape xml content when
displaying.

(cherry picked from commit a240dba)
cshannon added a commit that referenced this pull request Apr 17, 2026
This change makes sure we always use the correct content type for the
output based on the configured view and also escape xml content when
displaying.

(cherry picked from commit a240dba)
cshannon added a commit that referenced this pull request Apr 17, 2026
This change makes sure we always use the correct content type for the
output based on the configured view and also escape xml content when
displaying.

(cherry picked from commit a240dba)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants