Skip to content

Disable the message servlet by default#2000

Merged
cshannon merged 2 commits into
apache:mainfrom
cshannon:disable-message-servlet
May 13, 2026
Merged

Disable the message servlet by default#2000
cshannon merged 2 commits into
apache:mainfrom
cshannon:disable-message-servlet

Conversation

@cshannon
Copy link
Copy Markdown
Contributor

@cshannon cshannon commented May 11, 2026 •
edited
Loading

The servlet will still be enabled by default in the web demo project

Edit: I marked the servlet as deprecated and also added comments about why

@cshannon cshannon requested a review from jbonofre May 11, 2026 14:53
@jbertram
Copy link
Copy Markdown
Contributor

jbertram commented May 11, 2026

Does this mean that we're essentially dropping support for the REST messaging API?

@cshannon cshannon force-pushed the disable-message-servlet branch from ad8ac87 to 15d8d60 Compare May 11, 2026 15:18
@cshannon cshannon requested a review from mattrpav May 11, 2026 15:28
jbonofre
jbonofre previously approved these changes May 11, 2026
View reviewed changes
Comment thread assembly/src/release/webapps/api/WEB-INF/web.xml

<display-name>Apache ActiveMQ REST API</display-name>

<servlet>
Copy link
Copy Markdown
Member

@jbonofre jbonofre May 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe worth to keep in the file, but commented, just in case the user absolutely wants to use it.

Copy link
Copy Markdown
Contributor Author

@cshannon cshannon May 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I originally just commented it out but then removed it entirely (it's still the demo project). I can go either way though. @mattrpav what do you think?

Copy link
Copy Markdown
Contributor Author

@cshannon cshannon May 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was my original commit before force pushing: ad8ac87

Copy link
Copy Markdown
Contributor

@mattrpav mattrpav May 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with comment it out as a good step here. It'll surface questions from users needing to reanble it and we'll get a sense of how it is used.

Going forward (v7) there is probably a modernization task for this.

Copy link
Copy Markdown
Member

@jbonofre jbonofre May 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That sounds like a good plan.

@mattrpav
Copy link
Copy Markdown
Contributor

mattrpav commented May 11, 2026

Does this mean that we're essentially dropping support for the REST messaging API?

No. This is a security stance of being more “locked down” by default. Administrators are then encouraged to enable features and service they need

@cshannon cshannon force-pushed the disable-message-servlet branch from 15d8d60 to ad8ac87 Compare May 11, 2026 16:12
@cshannon cshannon requested a review from jbonofre May 11, 2026 16:12
mattrpav
mattrpav approved these changes May 13, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@mattrpav mattrpav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cshannon cshannon merged commit d8a8540 into apache:main May 13, 2026
9 of 10 checks passed
@github-project-automation github-project-automation Bot moved this from Backlog to Done in Apache ActiveMQ v6.3.0 May 13, 2026
@cshannon cshannon deleted the disable-message-servlet branch May 13, 2026 15:39
cshannon added a commit that referenced this pull request May 13, 2026
@cshannon
Disable the message servlet by default (#2000) (#2014)
8b5af8d 
* Disable the message servlet by default

* Add warning message and deprecated annotation

(cherry picked from commit d8a8540)
cshannon added a commit that referenced this pull request May 13, 2026
@cshannon
Disable the message servlet by default (#2000) (#2015)
d82f61f 
* Disable the message servlet by default

* Add warning message and deprecated annotation

(cherry picked from commit d8a8540)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattrpav mattrpav mattrpav approved these changes

@jbonofre jbonofre Awaiting requested review from jbonofre

Assignees

No one assigned

Labels

None yet

Projects

Apache ActiveMQ v6.3.0
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cshannon @jbertram @mattrpav @jbonofre