Skip to content

Commit 23146a4

Browse files
gregfeliceclaude
gregfelice
and
claude
authored
Fix crash in PREPARE with property parameter when enable_containment is off (#2339)
* Fix crash in PREPARE with property parameter when enable_containment is off When age.enable_containment is set to off, executing a PREPARE statement with a property parameter (e.g., MATCH (n $props) RETURN n) causes a segfault. The crash occurs in transform_map_to_ind_recursive because the property_constraints node is a cypher_param, not a cypher_map, but is blindly cast to cypher_map and its keyvals field is dereferenced. Three fixes: - In create_property_constraints, when enable_containment is off and the constraint is a cypher_param, fall back to the containment operator (@>) since map decomposition requires known keys at parse time. - In transform_match_entities, guard the keep_null assignment for both vertex and edge property constraints with is_ag_node checks to avoid writing to the wrong struct layout. Fixes #1964 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Fix @> vs @>> for =properties form with PREPARE and add tests When MATCH uses the =properties form (e.g., MATCH (n = $props)), the enable_containment=on path correctly uses @>> (top-level containment). The parameter fallback path unconditionally used @> (deep containment), ignoring the use_equals flag. Fix the fallback to mirror the enable_containment path by selecting @>> when use_equals is set. Add regression tests for =properties form with PREPARE for both vertices and edges, with enable_containment on and off. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
1 parent d0741d8 commit 23146a4

3 files changed

Lines changed: 223 additions & 2 deletions

File tree

‎regress/expected/cypher_match.out‎

Lines changed: 116 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3633,6 +3633,110 @@ NOTICE: graph "issue_2308" has been dropped
36333633

36343634
(1 row)
36353635

3636+
-- Issue 1964
3637+
--
3638+
-- PREPARE with property parameter ($props) crashed the server when
3639+
-- age.enable_containment was set to off. The crash was in
3640+
-- transform_map_to_ind_recursive which blindly cast cypher_param
3641+
-- nodes to cypher_map, accessing invalid memory.
3642+
--
3643+
SELECT create_graph('issue_1964');
3644+
NOTICE: graph "issue_1964" has been created
3645+
create_graph
3646+
--------------
3647+
3648+
(1 row)
3649+
3650+
SELECT * FROM cypher('issue_1964', $$
3651+
CREATE (:Person {name: 'Alice', age: 30}),
3652+
(:Person {name: 'Bob', age: 25})
3653+
$$) AS (result agtype);
3654+
result
3655+
--------
3656+
(0 rows)
3657+
3658+
SELECT * FROM cypher('issue_1964', $$
3659+
CREATE (:Person {name: 'Alice'})-[:KNOWS {since: 2020}]->(:Person {name: 'Bob'})
3660+
$$) AS (result agtype);
3661+
result
3662+
--------
3663+
(0 rows)
3664+
3665+
-- Test PREPARE with enable_containment off (was crashing)
3666+
SET age.enable_containment = off;
3667+
PREPARE issue_1964_vertex(agtype) AS
3668+
SELECT * FROM cypher('issue_1964',
3669+
$$MATCH (n $props) RETURN n $$, $1) AS (p agtype);
3670+
EXECUTE issue_1964_vertex('{"props": {"name": "Alice"}}');
3671+
p
3672+
------------------------------------------------------------------------------------------------
3673+
{"id": 844424930131969, "label": "Person", "properties": {"age": 30, "name": "Alice"}}::vertex
3674+
{"id": 844424930131971, "label": "Person", "properties": {"name": "Alice"}}::vertex
3675+
(2 rows)
3676+
3677+
EXECUTE issue_1964_vertex('{"props": {"age": 25}}');
3678+
p
3679+
----------------------------------------------------------------------------------------------
3680+
{"id": 844424930131970, "label": "Person", "properties": {"age": 25, "name": "Bob"}}::vertex
3681+
(1 row)
3682+
3683+
DEALLOCATE issue_1964_vertex;
3684+
-- Test edge property parameter with enable_containment off
3685+
PREPARE issue_1964_edge(agtype) AS
3686+
SELECT * FROM cypher('issue_1964',
3687+
$$MATCH ()-[r $props]->() RETURN r $$, $1) AS (p agtype);
3688+
EXECUTE issue_1964_edge('{"props": {"since": 2020}}');
3689+
p
3690+
-----------------------------------------------------------------------------------------------------------------------------------------
3691+
{"id": 1125899906842625, "label": "KNOWS", "end_id": 844424930131972, "start_id": 844424930131971, "properties": {"since": 2020}}::edge
3692+
(1 row)
3693+
3694+
DEALLOCATE issue_1964_edge;
3695+
-- Verify enable_containment on still works with PREPARE
3696+
SET age.enable_containment = on;
3697+
PREPARE issue_1964_vertex_on(agtype) AS
3698+
SELECT * FROM cypher('issue_1964',
3699+
$$MATCH (n $props) RETURN n $$, $1) AS (p agtype);
3700+
EXECUTE issue_1964_vertex_on('{"props": {"name": "Alice"}}');
3701+
p
3702+
------------------------------------------------------------------------------------------------
3703+
{"id": 844424930131969, "label": "Person", "properties": {"age": 30, "name": "Alice"}}::vertex
3704+
{"id": 844424930131971, "label": "Person", "properties": {"name": "Alice"}}::vertex
3705+
(2 rows)
3706+
3707+
DEALLOCATE issue_1964_vertex_on;
3708+
-- Test =properties form with PREPARE (uses @>> top-level containment)
3709+
SET age.enable_containment = off;
3710+
PREPARE issue_1964_vertex_eq(agtype) AS
3711+
SELECT * FROM cypher('issue_1964',
3712+
$$MATCH (n = $props) RETURN n $$, $1) AS (p agtype);
3713+
EXECUTE issue_1964_vertex_eq('{"props": {"name": "Alice", "age": 25}}');
3714+
p
3715+
---
3716+
(0 rows)
3717+
3718+
DEALLOCATE issue_1964_vertex_eq;
3719+
PREPARE issue_1964_edge_eq(agtype) AS
3720+
SELECT * FROM cypher('issue_1964',
3721+
$$MATCH ()-[r = $props]->() RETURN r $$, $1) AS (p agtype);
3722+
EXECUTE issue_1964_edge_eq('{"props": {"since": 2020}}');
3723+
p
3724+
-----------------------------------------------------------------------------------------------------------------------------------------
3725+
{"id": 1125899906842625, "label": "KNOWS", "end_id": 844424930131972, "start_id": 844424930131971, "properties": {"since": 2020}}::edge
3726+
(1 row)
3727+
3728+
DEALLOCATE issue_1964_edge_eq;
3729+
-- Same with enable_containment on
3730+
SET age.enable_containment = on;
3731+
PREPARE issue_1964_vertex_eq_on(agtype) AS
3732+
SELECT * FROM cypher('issue_1964',
3733+
$$MATCH (n = $props) RETURN n $$, $1) AS (p agtype);
3734+
EXECUTE issue_1964_vertex_eq_on('{"props": {"name": "Alice", "age": 25}}');
3735+
p
3736+
---
3737+
(0 rows)
3738+
3739+
DEALLOCATE issue_1964_vertex_eq_on;
36363740
--
36373741
-- Clean up
36383742
--
@@ -3721,6 +3825,18 @@ NOTICE: graph "issue_1393" has been dropped
37213825

37223826
(1 row)
37233827

3828+
SELECT drop_graph('issue_1964', true);
3829+
NOTICE: drop cascades to 4 other objects
3830+
DETAIL: drop cascades to table issue_1964._ag_label_vertex
3831+
drop cascades to table issue_1964._ag_label_edge
3832+
drop cascades to table issue_1964."Person"
3833+
drop cascades to table issue_1964."KNOWS"
3834+
NOTICE: graph "issue_1964" has been dropped
3835+
drop_graph
3836+
------------
3837+
3838+
(1 row)
3839+
37243840
--
37253841
-- End
37263842
--

‎regress/sql/cypher_match.sql‎

Lines changed: 67 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1491,6 +1491,72 @@ SELECT * FROM cypher('issue_2308', $$
14911491
$$) AS (val agtype);
14921492

14931493
SELECT drop_graph('issue_2308', true);
1494+
-- Issue 1964
1495+
--
1496+
-- PREPARE with property parameter ($props) crashed the server when
1497+
-- age.enable_containment was set to off. The crash was in
1498+
-- transform_map_to_ind_recursive which blindly cast cypher_param
1499+
-- nodes to cypher_map, accessing invalid memory.
1500+
--
1501+
1502+
SELECT create_graph('issue_1964');
1503+
SELECT * FROM cypher('issue_1964', $$
1504+
CREATE (:Person {name: 'Alice', age: 30}),
1505+
(:Person {name: 'Bob', age: 25})
1506+
$$) AS (result agtype);
1507+
SELECT * FROM cypher('issue_1964', $$
1508+
CREATE (:Person {name: 'Alice'})-[:KNOWS {since: 2020}]->(:Person {name: 'Bob'})
1509+
$$) AS (result agtype);
1510+
1511+
-- Test PREPARE with enable_containment off (was crashing)
1512+
SET age.enable_containment = off;
1513+
1514+
PREPARE issue_1964_vertex(agtype) AS
1515+
SELECT * FROM cypher('issue_1964',
1516+
$$MATCH (n $props) RETURN n $$, $1) AS (p agtype);
1517+
EXECUTE issue_1964_vertex('{"props": {"name": "Alice"}}');
1518+
EXECUTE issue_1964_vertex('{"props": {"age": 25}}');
1519+
DEALLOCATE issue_1964_vertex;
1520+
1521+
-- Test edge property parameter with enable_containment off
1522+
PREPARE issue_1964_edge(agtype) AS
1523+
SELECT * FROM cypher('issue_1964',
1524+
$$MATCH ()-[r $props]->() RETURN r $$, $1) AS (p agtype);
1525+
EXECUTE issue_1964_edge('{"props": {"since": 2020}}');
1526+
DEALLOCATE issue_1964_edge;
1527+
1528+
-- Verify enable_containment on still works with PREPARE
1529+
SET age.enable_containment = on;
1530+
1531+
PREPARE issue_1964_vertex_on(agtype) AS
1532+
SELECT * FROM cypher('issue_1964',
1533+
$$MATCH (n $props) RETURN n $$, $1) AS (p agtype);
1534+
EXECUTE issue_1964_vertex_on('{"props": {"name": "Alice"}}');
1535+
DEALLOCATE issue_1964_vertex_on;
1536+
1537+
-- Test =properties form with PREPARE (uses @>> top-level containment)
1538+
SET age.enable_containment = off;
1539+
1540+
PREPARE issue_1964_vertex_eq(agtype) AS
1541+
SELECT * FROM cypher('issue_1964',
1542+
$$MATCH (n = $props) RETURN n $$, $1) AS (p agtype);
1543+
EXECUTE issue_1964_vertex_eq('{"props": {"name": "Alice", "age": 25}}');
1544+
DEALLOCATE issue_1964_vertex_eq;
1545+
1546+
PREPARE issue_1964_edge_eq(agtype) AS
1547+
SELECT * FROM cypher('issue_1964',
1548+
$$MATCH ()-[r = $props]->() RETURN r $$, $1) AS (p agtype);
1549+
EXECUTE issue_1964_edge_eq('{"props": {"since": 2020}}');
1550+
DEALLOCATE issue_1964_edge_eq;
1551+
1552+
-- Same with enable_containment on
1553+
SET age.enable_containment = on;
1554+
1555+
PREPARE issue_1964_vertex_eq_on(agtype) AS
1556+
SELECT * FROM cypher('issue_1964',
1557+
$$MATCH (n = $props) RETURN n $$, $1) AS (p agtype);
1558+
EXECUTE issue_1964_vertex_eq_on('{"props": {"name": "Alice", "age": 25}}');
1559+
DEALLOCATE issue_1964_vertex_eq_on;
14941560

14951561
--
14961562
-- Clean up
@@ -1501,6 +1567,7 @@ SELECT drop_graph('test_enable_containment', true);
15011567
SELECT drop_graph('issue_945', true);
15021568
SELECT drop_graph('issue_1399', true);
15031569
SELECT drop_graph('issue_1393', true);
1570+
SELECT drop_graph('issue_1964', true);
15041571

15051572
--
15061573
-- End

‎src/backend/parser/cypher_clause.c‎

Lines changed: 40 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4261,6 +4261,38 @@ static Node *create_property_constraints(cypher_parsestate *cpstate,
42614261
}
42624262
else
42634263
{
4264+
/*
4265+
* Map decomposition into individual index lookups requires known
4266+
* keys at parse time. When the property constraint is a parameter
4267+
* (cypher_param), the keys are not available until execution, so
4268+
* fall back to the containment operator.
4269+
*/
4270+
if (is_ag_node(property_constraints, cypher_param))
4271+
{
4272+
/*
4273+
* Use @>> (top-level containment) for =properties form,
4274+
* @> (deep containment) otherwise — matching the
4275+
* enable_containment=on path above.
4276+
*/
4277+
if ((entity->type == ENT_VERTEX &&
4278+
entity->entity.node->use_equals) ||
4279+
((entity->type == ENT_EDGE ||
4280+
entity->type == ENT_VLE_EDGE) &&
4281+
entity->entity.rel->use_equals))
4282+
{
4283+
return (Node *)make_op(pstate,
4284+
list_make1(makeString("@>>")),
4285+
prop_expr, const_expr,
4286+
last_srf, -1);
4287+
}
4288+
else
4289+
{
4290+
return (Node *)make_op(pstate,
4291+
list_make1(makeString("@>")),
4292+
prop_expr, const_expr,
4293+
last_srf, -1);
4294+
}
4295+
}
42644296
return (Node *)transform_map_to_ind(
42654297
cpstate, entity, (cypher_map *)property_constraints);
42664298
}
@@ -4690,7 +4722,10 @@ static List *transform_match_entities(cypher_parsestate *cpstate, Query *query,
46904722
-1);
46914723
}
46924724

4693-
((cypher_map*)node->props)->keep_null = true;
4725+
if (is_ag_node(node->props, cypher_map))
4726+
{
4727+
((cypher_map*)node->props)->keep_null = true;
4728+
}
46944729
n = create_property_constraints(cpstate, entity, node->props,
46954730
prop_expr);
46964731

@@ -4819,7 +4854,10 @@ static List *transform_match_entities(cypher_parsestate *cpstate, Query *query,
48194854
false, -1);
48204855
}
48214856

4822-
((cypher_map*)rel->props)->keep_null = true;
4857+
if (is_ag_node(rel->props, cypher_map))
4858+
{
4859+
((cypher_map*)rel->props)->keep_null = true;
4860+
}
48234861
r = create_property_constraints(cpstate, entity, rel->props,
48244862
prop_expr);
48254863

0 commit comments

Comments
 (0)