Commit 5d11080
Address Copilot review: comment placement, %expect docs, test wording
1. Move "Helper function to create an ExplainStmt node" comment from
above make_exists_pattern_sublink() to above make_explain_stmt()
where it belongs.
2. Add block comment documenting the %expect/%expect-rr conflict
budget: 7 S/R from path vs arithmetic on - and <, 3 R/R from
expr_var vs var_name_opt on ) } =.
3. Clarify test comment: "Regular expressions" -> "Regular (non-pattern)
expressions" to avoid confusion with regex.
Regression test: pattern_expression OK.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>1 parent cd0aebc commit 5d11080
3 files changed
Lines changed: 16 additions & 3 deletions
File tree
- regress
- expected
- sql
- src/backend/parser
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
193 | 193 | | |
194 | 194 | | |
195 | 195 | | |
196 | | - | |
| 196 | + | |
197 | 197 | | |
198 | 198 | | |
199 | 199 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
141 | 141 | | |
142 | 142 | | |
143 | 143 | | |
144 | | - | |
| 144 | + | |
145 | 145 | | |
146 | 146 | | |
147 | 147 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
58 | 58 | | |
59 | 59 | | |
60 | 60 | | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
61 | 74 | | |
62 | 75 | | |
63 | 76 | | |
| |||
3328 | 3341 | | |
3329 | 3342 | | |
3330 | 3343 | | |
3331 | | - | |
3332 | 3344 | | |
3333 | 3345 | | |
3334 | 3346 | | |
| |||
3353 | 3365 | | |
3354 | 3366 | | |
3355 | 3367 | | |
| 3368 | + | |
3356 | 3369 | | |
3357 | 3370 | | |
3358 | 3371 | | |
| |||
0 commit comments