Support PostgreSQL 19

code cleanly compiles and tests pass
difference in tests output mainly caused by changes in Postgres error
reporting.

Author: CyberDem0n

.github/workflows/installcheck.yaml

@@ -12,34 +12,34 @@ jobs:
     runs-on: ubuntu-latest
 
     steps:
-      - name: Get latest commit id of PostgreSQL 18
+      - name: Get latest commit id of PostgreSQL 19
         run: |
-          echo "PG_COMMIT_HASH=$(git ls-remote https://git.postgresql.org/git/postgresql.git refs/heads/REL_18_STABLE | awk '{print $1}')" >> $GITHUB_ENV
+          echo "PG_COMMIT_HASH=$(git ls-remote https://git.postgresql.org/git/postgresql.git refs/heads/master | awk '{print $1}')" >> $GITHUB_ENV
 
-      - name: Cache PostgreSQL 18
+      - name: Cache PostgreSQL 19
         uses: actions/cache@v3
-        id: pg18cache
+        id: pg19cache
         with:
-          path: ~/pg18
-          key: ${{ runner.os }}-v1-pg18-${{ env.PG_COMMIT_HASH }}
+          path: ~/pg19
+          key: ${{ runner.os }}-v1-pg19-${{ env.PG_COMMIT_HASH }}
 
       - name: Install necessary dependencies
         run: |
           sudo apt-get update
           sudo apt-get install -y build-essential libreadline-dev zlib1g-dev flex bison
 
-      - name: Install PostgreSQL 18 and some extensions
-        if: steps.pg18cache.outputs.cache-hit != 'true'
+      - name: Install PostgreSQL 19 and some extensions
+        if: steps.pg19cache.outputs.cache-hit != 'true'
         run: |
-          git clone --depth 1 --branch REL_18_STABLE https://git.postgresql.org/git/postgresql.git ~/pg18source
-          cd ~/pg18source
-          ./configure --prefix=$HOME/pg18 CFLAGS="-std=gnu99 -ggdb -O0" --enable-cassert
+          git clone --depth 1 --branch master https://git.postgresql.org/git/postgresql.git ~/pg19source
+          cd ~/pg19source
+          ./configure --prefix=$HOME/pg19 CFLAGS="-std=gnu99 -ggdb -O0" --enable-cassert
           make install -j$(nproc) > /dev/null
           cd contrib
           cd fuzzystrmatch
-          make PG_CONFIG=$HOME/pg18/bin/pg_config install -j$(nproc) > /dev/null
+          make PG_CONFIG=$HOME/pg19/bin/pg_config install -j$(nproc) > /dev/null
           cd ../pg_trgm
-          make PG_CONFIG=$HOME/pg18/bin/pg_config install -j$(nproc) > /dev/null
+          make PG_CONFIG=$HOME/pg19/bin/pg_config install -j$(nproc) > /dev/null
 
       - uses: actions/checkout@v3
         with:
@@ -48,19 +48,19 @@ jobs:
       - name: Build AGE
         id: build
         run: |
-          make PG_CONFIG=$HOME/pg18/bin/pg_config COPT=-Werror install -j$(nproc)
+          make PG_CONFIG=$HOME/pg19/bin/pg_config COPT=-Werror install -j$(nproc)
 
       - name: Pull and build pgvector
         id: pgvector
         run: |
           git clone https://github.com/pgvector/pgvector.git
           cd pgvector
-          make PG_CONFIG=$HOME/pg18/bin/pg_config install -j$(nproc) > /dev/null
+          make PG_CONFIG=$HOME/pg19/bin/pg_config install -j$(nproc) > /dev/null
 
       - name: Regression tests
         id: regression_tests
         run: |
-          make PG_CONFIG=$HOME/pg18/bin/pg_config installcheck EXTRA_TESTS="pgvector fuzzystrmatch pg_trgm"
+          make PG_CONFIG=$HOME/pg19/bin/pg_config installcheck EXTRA_TESTS="pgvector fuzzystrmatch pg_trgm"
         continue-on-error: true
 
       - name: Dump regression test errors

regress/expected/age_load.out

@@ -55,8 +55,8 @@ SELECT currval('agload_test_graph."Country_id_seq"')=248;
 -- Should error out on loading the same file again due to duplicate id
 SELECT load_labels_from_file('agload_test_graph', 'Country',
     'age_load/countries.csv', true);
-ERROR:  Cannot insert duplicate vertex id: 844424930131970
-HINT:  Entry id 2 is already used
+ERROR:  duplicate key value violates unique constraint "Country_pkey"
+DETAIL:  Key (id)=(844424930131970) already exists.
 --
 -- Load cities with id
 --
@@ -79,8 +79,8 @@ SELECT currval('agload_test_graph."City_id_seq"')=146941;
 -- Should error out on loading the same file again due to duplicate id
 SELECT load_labels_from_file('agload_test_graph', 'City',
     'age_load/cities.csv', true);
-ERROR:  Cannot insert duplicate vertex id: 1125899906842777
-HINT:  Entry id 153 is already used
+ERROR:  duplicate key value violates unique constraint "City_pkey"
+DETAIL:  Key (id)=(1125899906842777) already exists.
 --
 -- Load edges -- Connects cities to countries
 --

regress/expected/cypher_call.out

@@ -80,7 +80,6 @@ SELECT * FROM cypher('cypher_call', $$CALL ag_catalog.add_agtype(1,2)$$) as (sqr
 ERROR:  function ag_catalog.add_agtype(agtype, agtype) does not exist
 LINE 2: ...cypher('cypher_call', $$CALL ag_catalog.add_agtype(1,2)$$) a...
                                                              ^
-HINT:  No function matches the given name and argument types. You might need to add explicit type casts.
 /* CALL YIELD WHERE, should fail */
 SELECT * FROM cypher('cypher_call', $$CALL sqrt(64) YIELD sqrt WHERE sqrt > 1$$) as (sqrt agtype);
 ERROR:  Cannot use standalone CALL with WHERE
@@ -287,12 +286,11 @@ SELECT * FROM cypher('cypher_call', $$ CALL ag_catalog.myfunc() YIELD myfunc RET
 ERROR:  function ag_catalog.myfunc() does not exist
 LINE 1: ...T * FROM cypher('cypher_call', $$ CALL ag_catalog.myfunc() Y...
                                                              ^
-HINT:  No function matches the given name and argument types. You might need to add explicit type casts.
+DETAIL:  No function of that name accepts the given number of arguments.
 SELECT * FROM cypher('cypher_call', $$ CALL ag_catalog.myfunz(25) YIELD myfunc RETURN myfunc $$) as (result agtype);
 ERROR:  function ag_catalog.myfunz(agtype) does not exist
 LINE 1: ...OM cypher('cypher_call', $$ CALL ag_catalog.myfunz(25) YIELD...
                                                              ^
-HINT:  No function matches the given name and argument types. You might need to add explicit type casts.
 DROP FUNCTION myfunc;
 DROP SCHEMA call_stmt_test CASCADE;
 NOTICE:  drop cascades to function call_stmt_test.add_agtype(agtype,agtype)

regress/expected/cypher_match.out

@@ -336,10 +336,10 @@ SELECT * FROM cypher('cypher_match', $$
 $$) AS (i agtype);
                                                                                                                                                   i                                                                                                                                                   
 ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
- [{"id": 1688849860263938, "label": "v2", "properties": {"id": "middle"}}::vertex, {"id": 1970324836974594, "label": "e2", "end_id": 1688849860263937, "start_id": 1688849860263938, "properties": {}}::edge, {"id": 1688849860263937, "label": "v2", "properties": {"id": "initial"}}::vertex]::path
  [{"id": 1688849860263938, "label": "v2", "properties": {"id": "middle"}}::vertex, {"id": 1970324836974593, "label": "e2", "end_id": 1688849860263939, "start_id": 1688849860263938, "properties": {}}::edge, {"id": 1688849860263939, "label": "v2", "properties": {"id": "end"}}::vertex]::path
  [{"id": 1688849860263938, "label": "v2", "properties": {"id": "middle"}}::vertex, {"id": 1970324836974594, "label": "e2", "end_id": 1688849860263937, "start_id": 1688849860263938, "properties": {}}::edge, {"id": 1688849860263937, "label": "v2", "properties": {"id": "initial"}}::vertex]::path
  [{"id": 1688849860263938, "label": "v2", "properties": {"id": "middle"}}::vertex, {"id": 1970324836974593, "label": "e2", "end_id": 1688849860263939, "start_id": 1688849860263938, "properties": {}}::edge, {"id": 1688849860263939, "label": "v2", "properties": {"id": "end"}}::vertex]::path
+ [{"id": 1688849860263938, "label": "v2", "properties": {"id": "middle"}}::vertex, {"id": 1970324836974594, "label": "e2", "end_id": 1688849860263937, "start_id": 1688849860263938, "properties": {}}::edge, {"id": 1688849860263937, "label": "v2", "properties": {"id": "initial"}}::vertex]::path
 (4 rows)
 
 SELECT * FROM cypher('cypher_match', $$
@@ -1494,14 +1494,14 @@ AS (u agtype);
 ERROR:  function ag_catalog.age_isempty(agtype, agtype, agtype) does not exist
 LINE 2:  $$MATCH (u:for_pred) WHERE isEmpty(1,2,3) RETURN properties...
                                            ^
-HINT:  No function matches the given name and argument types. You might need to add explicit type casts.
+DETAIL:  No function of that name accepts the given number of arguments.
 SELECT * FROM cypher('for_isEmpty',
  $$MATCH (u:for_pred) WHERE isEmpty() RETURN properties(u) $$)
 AS (u agtype);
 ERROR:  function ag_catalog.age_isempty() does not exist
 LINE 2:  $$MATCH (u:for_pred) WHERE isEmpty() RETURN properties(u) $...
                                     ^
-HINT:  No function matches the given name and argument types. You might need to add explicit type casts.
+DETAIL:  No function of that name accepts the given number of arguments.
 -- clean up
 SELECT drop_graph('for_isEmpty', true);
 NOTICE:  drop cascades to 3 other objects