Skip to content

Commit 061ca08

Browse files
committed
UI: Remove unnecessary useCallback in useMonacoTheme
Address review feedback: React Compiler handles memoization, so the useCallback wrapper around defineAirflowMonacoThemes is redundant. Pass the function reference directly instead. Also fix prettier formatting in tests.
1 parent 8124831 commit 061ca08

2 files changed

Lines changed: 2 additions & 10 deletions

File tree

airflow-core/src/airflow/ui/src/context/colorMode/useMonacoTheme.test.ts

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -99,10 +99,7 @@ describe("useMonacoTheme", () => {
9999

100100
expect(defineTheme).toHaveBeenCalledTimes(2);
101101
expect(defineTheme).toHaveBeenCalledWith("airflow-light", expect.objectContaining({ base: "vs" }));
102-
expect(defineTheme).toHaveBeenCalledWith(
103-
"airflow-dark",
104-
expect.objectContaining({ base: "vs-dark" }),
105-
);
102+
expect(defineTheme).toHaveBeenCalledWith("airflow-dark", expect.objectContaining({ base: "vs-dark" }));
106103
});
107104

108105
it("does not re-register themes on subsequent beforeMount calls", async () => {

airflow-core/src/airflow/ui/src/context/colorMode/useMonacoTheme.ts

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
* under the License.
1818
*/
1919
import type { Monaco } from "@monaco-editor/react";
20-
import { useCallback } from "react";
2120

2221
import { useColorMode } from "./useColorMode";
2322

@@ -115,12 +114,8 @@ const defineAirflowMonacoThemes = (monaco: Monaco) => {
115114
export const useMonacoTheme = () => {
116115
const { colorMode } = useColorMode();
117116

118-
const beforeMount = useCallback((monaco: Monaco) => {
119-
defineAirflowMonacoThemes(monaco);
120-
}, []);
121-
122117
return {
123-
beforeMount,
118+
beforeMount: defineAirflowMonacoThemes,
124119
theme: colorMode === "dark" ? DARK_THEME_NAME : LIGHT_THEME_NAME,
125120
};
126121
};

0 commit comments

Comments
 (0)