Commit 4ad460d
Fix bulk task instance update for mapped TIs and auth error rendering (#65874)
On v3-2-test, BulkTaskInstanceService had three pre-existing bugs:
1. `_perform_update` did not pass `map_index` to
`_patch_ti_validate_request`, so the validation step looked up the
wrong TI (default map_index=-1) and persistence silently no-op'd
for mapped task instances.
2. `specific_entity_map` and `all_map_entity_map` used raw
`(entity.dag_id, entity.dag_run_id, entity.task_id, ...)` tuples
as keys. When `dag_id`/`dag_run_id` came from the path and not the
request body, those attributes were `None` on the entity, while
keys produced by `_categorize_entities` resolved them via
`_extract_task_identifiers`. The resulting key mismatch meant
matched task keys never resolved back to an entity, so
`_perform_update` was never called and `response.update.success`
came back empty.
3. `action_name=action.action` rendered as `'BulkAction.UPDATE'`
/`'BulkAction.DELETE'` in authorization error messages because
Python's str-enum `__format__` returns the enum repr, not the
value. Use `.value` to get "update"/"delete".
All three fixes already exist on main; this backport is the minimal
diff to bring v3-2-test in line with main for this file.
Also includes the following pre-existing v3-2-test fixes that the
prek hooks force to land alongside any source change:
- Regenerated _private_ui.yaml, schemas.gen.ts and types.gen.ts:
generate-openapi-spec caught a description drift on `ExtraMenuItem`.
- Added `fpr` to docs/spelling_wordlist.txt: codespell flagged the
GPG colons-format `^fpr:` regex tag in dev/README_RELEASE_*.md.
Same fix already on main from #65501.
- Regenerated dev/breeze/doc/images/output_pr_auto-triage.{svg,txt}:
the boring-cyborg config update in #65872 added the
`backport-to-airflow-ctl-v0-1-test` label, which appears in the
`breeze pr auto-triage --help` output and changes its hash.1 parent 5b0362a commit 4ad460d
7 files changed
Lines changed: 28 additions & 20 deletions
File tree
- airflow-core/src/airflow
- api_fastapi/core_api
- openapi
- services/public
- ui/openapi-gen/requests
- dev/breeze/doc/images
- docs
Lines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2215 | 2215 | | |
2216 | 2216 | | |
2217 | 2217 | | |
| 2218 | + | |
| 2219 | + | |
2218 | 2220 | | |
2219 | 2221 | | |
2220 | 2222 | | |
| |||
Lines changed: 5 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
299 | 299 | | |
300 | 300 | | |
301 | 301 | | |
| 302 | + | |
302 | 303 | | |
303 | 304 | | |
304 | 305 | | |
| |||
337 | 338 | | |
338 | 339 | | |
339 | 340 | | |
340 | | - | |
| 341 | + | |
341 | 342 | | |
342 | 343 | | |
343 | 344 | | |
344 | 345 | | |
345 | | - | |
| 346 | + | |
346 | 347 | | |
347 | 348 | | |
348 | 349 | | |
349 | 350 | | |
350 | | - | |
| 351 | + | |
351 | 352 | | |
352 | 353 | | |
353 | 354 | | |
| |||
439 | 440 | | |
440 | 441 | | |
441 | 442 | | |
442 | | - | |
| 443 | + | |
443 | 444 | | |
444 | 445 | | |
445 | 446 | | |
| |||
Lines changed: 2 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8125 | 8125 | | |
8126 | 8126 | | |
8127 | 8127 | | |
8128 | | - | |
| 8128 | + | |
| 8129 | + | |
8129 | 8130 | | |
8130 | 8131 | | |
8131 | 8132 | | |
| |||
Lines changed: 3 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1985 | 1985 | | |
1986 | 1986 | | |
1987 | 1987 | | |
| 1988 | + | |
| 1989 | + | |
| 1990 | + | |
1988 | 1991 | | |
1989 | 1992 | | |
1990 | 1993 | | |
| |||
Loading
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
651 | 651 | | |
652 | 652 | | |
653 | 653 | | |
| 654 | + | |
654 | 655 | | |
655 | 656 | | |
656 | 657 | | |
| |||
0 commit comments