Skip to content

Commit 8b7af09

Browse files
radu-gheorghepotiuk
authored andcommitted
fixing mypy issues
1 parent 9bc08a9 commit 8b7af09

2 files changed

Lines changed: 7 additions & 6 deletions

File tree

providers/vespa/src/airflow/providers/vespa/hooks/vespa.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616
# under the License.
1717
from __future__ import annotations
1818

19-
import types
2019
import uuid
2120
from collections.abc import Callable, Iterable
2221
from queue import Empty, Queue
@@ -94,12 +93,16 @@ def __init__(
9493
conn: Connection = self.get_connection(conn_id)
9594
self.conn = conn
9695
extra = self.conn.extra_dejson or {}
96+
host = self.conn.host
97+
98+
if not host:
99+
raise ValueError("Vespa connection requires a host")
97100

98101
resolved_schema = schema or self.conn.schema or self._get_field(extra, "schema")
99102
resolved_namespace = namespace or self._get_field(extra, "namespace") or "default"
100103

101104
self._configure_from_connection(
102-
host=self.conn.host,
105+
host=host,
103106
port=self.conn.port,
104107
namespace=resolved_namespace,
105108
schema=resolved_schema,
@@ -126,8 +129,6 @@ def from_resolved_connection(
126129
self = cls.__new__(cls)
127130
BaseHook.__init__(self)
128131

129-
self.conn = types.SimpleNamespace(host=host, extra=extra)
130-
131132
resolved_schema = schema or cls._get_field(extra, "schema")
132133
resolved_namespace = namespace or cls._get_field(extra, "namespace") or "default"
133134

providers/vespa/tests/system/vespa/example_dag_vespa.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -104,9 +104,9 @@ def run_query(yql: str, params: dict | None = None):
104104
send_batches >> [update_doc3, delete_doc4] >> verify_docs_task
105105

106106

107-
dag = vespa_dynamic()
107+
example_dag = vespa_dynamic()
108108

109109

110110
from tests_common.test_utils.system_tests import get_test_run # noqa: E402
111111

112-
test_run = get_test_run(dag)
112+
test_run = get_test_run(example_dag)

0 commit comments

Comments
 (0)