Refactor Service Account workers tests

Author: Miretpl

helm-tests/tests/helm_tests/airflow_core/test_worker.py

@@ -2251,51 +2251,38 @@ def test_should_add_component_specific_labels(self):
 class TestWorkerServiceAccount:
     """Tests worker service account."""
 
-    def test_should_add_component_specific_labels(self):
+    def test_should_not_create_worker_service_account_for_local_executor(self):
         docs = render_chart(
             values={
-                "executor": "CeleryExecutor",
-                "workers": {
-                    "serviceAccount": {"create": True},
-                    "labels": {"test_label": "test_label_value"},
-                },
+                "executor": "LocalExecutor",
+                "workers": {"serviceAccount": {"create": True}},
             },
             show_only=["templates/workers/worker-serviceaccount.yaml"],
         )
 
-        assert "test_label" in jmespath.search("metadata.labels", docs[0])
-        assert jmespath.search("metadata.labels", docs[0])["test_label"] == "test_label_value"
+        assert len(docs) == 0
 
     @pytest.mark.parametrize(
-        ("executor", "creates_service_account"),
+        "executor",
         [
-            ("LocalExecutor", False),
-            ("CeleryExecutor", True),
-            ("CeleryKubernetesExecutor", True),
-            ("CeleryExecutor,KubernetesExecutor", True),
-            ("KubernetesExecutor", True),
-            ("LocalKubernetesExecutor", True),
+            "CeleryExecutor",
+            "CeleryKubernetesExecutor",
+            "CeleryExecutor,KubernetesExecutor",
+            "KubernetesExecutor",
+            "LocalKubernetesExecutor",
         ],
     )
-    def test_should_create_worker_service_account_for_specific_executors(
-        self, executor, creates_service_account
-    ):
+    def test_should_create_worker_service_account_for_specific_executors(self, executor):
         docs = render_chart(
             values={
                 "executor": executor,
-                "workers": {
-                    "serviceAccount": {"create": True},
-                    "labels": {"test_label": "test_label_value"},
-                },
+                "workers": {"serviceAccount": {"create": True}},
             },
             show_only=["templates/workers/worker-serviceaccount.yaml"],
         )
-        if creates_service_account:
-            assert jmespath.search("kind", docs[0]) == "ServiceAccount"
-            assert "test_label" in jmespath.search("metadata.labels", docs[0])
-            assert jmespath.search("metadata.labels", docs[0])["test_label"] == "test_label_value"
-        else:
-            assert docs == []
+
+        assert len(docs) == 1
+        assert jmespath.search("kind", docs[0]) == "ServiceAccount"
 
     def test_default_automount_service_account_token(self):
         docs = render_chart(
@@ -2308,7 +2295,7 @@ def test_default_automount_service_account_token(self):
         )
         assert jmespath.search("automountServiceAccountToken", docs[0]) is True
 
-    def test_overridden_automount_service_account_token(self):
+    def test_override_automount_service_account_token(self):
         docs = render_chart(
             values={
                 "workers": {
@@ -2317,4 +2304,32 @@ def test_overridden_automount_service_account_token(self):
             },
             show_only=["templates/workers/worker-serviceaccount.yaml"],
         )
+
         assert jmespath.search("automountServiceAccountToken", docs[0]) is False
+
+    def test_override_name(self):
+        docs = render_chart(
+            values={
+                "workers": {
+                    "serviceAccount": {"create": True, "name": "test"},
+                },
+            },
+            show_only=["templates/workers/worker-serviceaccount.yaml"],
+        )
+
+        assert jmespath.search("metadata.name", docs[0]) == "test"
+
+    def test_should_add_component_specific_labels(self):
+        docs = render_chart(
+            values={
+                "executor": "CeleryExecutor",
+                "workers": {
+                    "serviceAccount": {"create": True},
+                    "labels": {"test_label": "test_label_value"},
+                },
+            },
+            show_only=["templates/workers/worker-serviceaccount.yaml"],
+        )
+
+        assert "test_label" in jmespath.search("metadata.labels", docs[0])
+        assert jmespath.search("metadata.labels", docs[0])["test_label"] == "test_label_value"