test(dag): persist DagModel before DatasetDagRunQueue in unit tests

leossantos · leossantos · commit e4d014e9025d · 2026-03-27T19:16:13.000-03:00
Split DagModel and DatasetDagRunQueue inserts and flush after DagModel so foreign-key order matches production DB constraints in TestDagModel.
diff --git a/tests/models/test_dag.py b/tests/models/test_dag.py
@@ -3087,6 +3087,7 @@ def test_dags_needing_dagruns_skips_ddrq_when_serialized_dag_missing(self, sessi
                 is_paused=False,
             )
         )
+        session.flush()
         session.add(DatasetDagRunQueue(dataset_id=dataset_id, target_dag_id=orphan_dag_id))
         session.flush()
 
@@ -3138,6 +3139,12 @@ def test_dags_needing_dagruns_missing_serialized_warning_lists_sorted_dag_ids(se
                     has_import_errors=False,
                     is_paused=False,
                 ),
+            ]
+        )
+        session.flush()
+
+        session.add_all(
+            [
                 DatasetDagRunQueue(dataset_id=ds_z_id, target_dag_id="ghost_z"),
                 DatasetDagRunQueue(dataset_id=ds_a_id, target_dag_id="ghost_a"),
             ]

Original file line number	Diff line number	Diff line change
`@@ -3087,6 +3087,7 @@ def test_dags_needing_dagruns_skips_ddrq_when_serialized_dag_missing(self, sessi`
`3087`	`3087`	`is_paused=False,`
`3088`	`3088`	`)`
`3089`	`3089`	`)`
	`3090`	`+ session.flush()`
`3090`	`3091`	`session.add(DatasetDagRunQueue(dataset_id=dataset_id, target_dag_id=orphan_dag_id))`
`3091`	`3092`	`session.flush()`
`3092`	`3093`
`@@ -3138,6 +3139,12 @@ def test_dags_needing_dagruns_missing_serialized_warning_lists_sorted_dag_ids(se`
`3138`	`3139`	`has_import_errors=False,`
`3139`	`3140`	`is_paused=False,`
`3140`	`3141`	`),`
	`3142`	`+ ]`
	`3143`	`+ )`
	`3144`	`+ session.flush()`
	`3145`	`+`
	`3146`	`+ session.add_all(`
	`3147`	`+ [`
`3141`	`3148`	`DatasetDagRunQueue(dataset_id=ds_z_id, target_dag_id="ghost_z"),`
`3142`	`3149`	`DatasetDagRunQueue(dataset_id=ds_a_id, target_dag_id="ghost_a"),`
`3143`	`3150`	`]`