Skip to content

Improve Monaco editor styling to better match Airflow UI#64290

Closed
saikiranyt2001 wants to merge 2 commits intoapache:mainfrom
saikiranyt2001:patch-1
Closed

Improve Monaco editor styling to better match Airflow UI#64290
saikiranyt2001 wants to merge 2 commits intoapache:mainfrom
saikiranyt2001:patch-1

Conversation

@saikiranyt2001
Copy link
Copy Markdown

The Monaco editor currently does not fully align with the Airflow UI design system.

This PR improves visual consistency by:

  • Aligning font with Airflow mono font
  • Adding padding for better readability
  • Applying Chakra UI surface background
  • Improving overall UI consistency

These changes make the editor feel more integrated with the overall UI.

Closes : #64253

- Align font with Airflow mono font
- Add padding for better readability
- Apply Chakra UI surface background
- Improve overall UI consistency
@boring-cyborg
Copy link
Copy Markdown

boring-cyborg bot commented Mar 27, 2026

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@boring-cyborg boring-cyborg bot added the area:UI Related to UI/UX. For Frontend Developers. label Mar 27, 2026
@saikiranyt2001
Copy link
Copy Markdown
Author

This update improves Monaco editor styling for better UI consistency and alignment with the Airflow design system.

@shivaam
Copy link
Copy Markdown
Contributor

shivaam commented Mar 27, 2026

Is it possible to add a demo of your testing?

@potiuk
Copy link
Copy Markdown
Member

potiuk commented Apr 1, 2026

@saikiranyt2001 This PR has a few issues that need to be addressed before it can be reviewed — please see our Pull Request quality criteria.

Issues found:

  • Pre-commit / static checks: Failing: CI image checks / Static checks. Run prek run --from-ref main locally to find and fix issues. See Pre-commit / static checks docs.

Note: Your branch is 102 commits behind main. Some check failures may be caused by changes in the base branch rather than by your PR. Please rebase your branch and push again to get up-to-date CI results.

What to do next:

  • The comment informs you what you need to do.
  • Fix each issue, then mark the PR as "Ready for review" in the GitHub UI - but only after making sure that all the issues are fixed.
  • There is no rush — take your time and work at your own pace. We appreciate your contribution and are happy to wait for updates.
  • Maintainers will then proceed with a normal review.

There is no rush — take your time and work at your own pace. We appreciate your contribution and are happy to wait for updates. If you have questions, feel free to ask on the Airflow Slack.

Copy link
Copy Markdown
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is only updating the JsonEditor but there are other places in the codebase where the monaco editor is used. Can you also update those other places?

Also can you provide screenshots of before/after change.

@kaxil kaxil requested a review from Copilot April 2, 2026 00:42
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copy link
Copy Markdown
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Closing in favor of #64748 that will also handle custom themes and make a more integrated theme I believe. (and also taking care of other locations update)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UI Related to UI/UX. For Frontend Developers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rework style for the monaco-editor

5 participants