Improve Monaco editor styling to better match Airflow UI#64290
Improve Monaco editor styling to better match Airflow UI#64290saikiranyt2001 wants to merge 2 commits intoapache:mainfrom
Conversation
- Align font with Airflow mono font - Add padding for better readability - Apply Chakra UI surface background - Improve overall UI consistency
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
|
This update improves Monaco editor styling for better UI consistency and alignment with the Airflow design system. |
|
Is it possible to add a demo of your testing? |
|
@saikiranyt2001 This PR has a few issues that need to be addressed before it can be reviewed — please see our Pull Request quality criteria. Issues found:
What to do next:
There is no rush — take your time and work at your own pace. We appreciate your contribution and are happy to wait for updates. If you have questions, feel free to ask on the Airflow Slack. |
pierrejeambrun
left a comment
There was a problem hiding this comment.
This is only updating the JsonEditor but there are other places in the codebase where the monaco editor is used. Can you also update those other places?
Also can you provide screenshots of before/after change.
There was a problem hiding this comment.
Closing in favor of #64748 that will also handle custom themes and make a more integrated theme I believe. (and also taking care of other locations update)
The Monaco editor currently does not fully align with the Airflow UI design system.
This PR improves visual consistency by:
These changes make the editor feel more integrated with the overall UI.
Closes : #64253