Fix task_defer method with non-JSON next_kwargs in TaskInstance#64714
Open
dabla wants to merge 3 commits intoapache:mainfrom
Open
Fix task_defer method with non-JSON next_kwargs in TaskInstance#64714dabla wants to merge 3 commits intoapache:mainfrom
dabla wants to merge 3 commits intoapache:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Fixes TaskInstance.defer_task() so next_kwargs containing non-JSON-serializable objects (e.g., datetime, timedelta) are converted into a JSON-safe form before being persisted.
Changes:
- Serialize
start_trigger_args.next_kwargsvia Airflow SDK serde before assigning toTaskInstance.next_kwargs. - Add a unit test covering
defer_task()with non-JSON-nativenext_kwargsvalues.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| airflow-core/src/airflow/models/taskinstance.py | Serializes next_kwargs during deferral to avoid non-JSON values being stored. |
| airflow-core/tests/unit/models/test_taskinstance.py | Adds regression test verifying serde roundtrip for non-JSON next_kwargs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix serialization in task_defer method with non-JSON next_kwargs of TaskInstance as mentioned by @kaxil in PR #55068.
Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.