Skip to content

Add workers.celery.serviceAccount & workers.kubernetes.serviceAccount#64730

Merged
jscheffl merged 6 commits intoapache:mainfrom
Miretpl:add-workers-celery-k8s-sa
Apr 7, 2026
Merged

Add workers.celery.serviceAccount & workers.kubernetes.serviceAccount#64730
jscheffl merged 6 commits intoapache:mainfrom
Miretpl:add-workers-celery-k8s-sa

Conversation

@Miretpl
Copy link
Copy Markdown
Contributor

@Miretpl Miretpl commented Apr 4, 2026

related: #28880

This PR introduces two new sections: workers.celery.serviceAccount and workers.kubernetes.serviceAccount. The workers.serviceAccount section is now deprecated.

In terms of logic, it works a little differently than other fields/sections moved to the workers.celery/workers.kubernetes section. All fields under workers.celery override values under workers section, but when workers.kubernetes section is used, the Service Account is generated from templates/workers/worker-kubernetes-serviceaccount.yaml file instead of templates/workers/worker-serviceaccount.yaml. Despite that separation, some fields have fallbacks to the workers section to match behaviour of other, already moved, fields/sections.

Additional change - all ServiceAccount was changed to Service Account in values.yaml as that was missed.


Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@boring-cyborg boring-cyborg Bot added the area:helm-chart Airflow Helm Chart label Apr 4, 2026
@Miretpl Miretpl force-pushed the add-workers-celery-k8s-sa branch 2 times, most recently from bcbbe1f to bb36637 Compare April 4, 2026 19:04
@Miretpl Miretpl force-pushed the add-workers-celery-k8s-sa branch from bb36637 to 1a6a79a Compare April 7, 2026 18:24
@Miretpl Miretpl marked this pull request as ready for review April 7, 2026 18:31
@jscheffl jscheffl added the backport-to-chart/v1-2x-test Automatic backport to chart 1.2x maintenance branch label Apr 7, 2026
@jscheffl jscheffl merged commit 59ddf56 into apache:main Apr 7, 2026
142 checks passed
github-actions Bot pushed a commit that referenced this pull request Apr 7, 2026
…etes.serviceAccount (#64730)

* Refactor Service Account workers tests

* Add workers.celery.serviceAccount & workers.kubernetes.serviceAccount

* Fix spellcheck

* Separate ServiceAccount names

* Add newsfragment

* Misc
(cherry picked from commit 59ddf56)

Co-authored-by: Przemysław Mirowski <17602603+Miretpl@users.noreply.github.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 7, 2026

Backport successfully created: chart/v1-2x-test

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

Status Branch Result
chart/v1-2x-test PR Link

jscheffl pushed a commit that referenced this pull request Apr 7, 2026
…etes.serviceAccount (#64730) (#64862)

* Refactor Service Account workers tests

* Add workers.celery.serviceAccount & workers.kubernetes.serviceAccount

* Fix spellcheck

* Separate ServiceAccount names

* Add newsfragment

* Misc
(cherry picked from commit 59ddf56)

Co-authored-by: Przemysław Mirowski <17602603+Miretpl@users.noreply.github.com>
@Miretpl Miretpl deleted the add-workers-celery-k8s-sa branch April 7, 2026 20:33
shivaam pushed a commit to shivaam/airflow that referenced this pull request Apr 8, 2026
…apache#64730)

* Refactor Service Account workers tests

* Add workers.celery.serviceAccount & workers.kubernetes.serviceAccount

* Fix spellcheck

* Separate ServiceAccount names

* Add newsfragment

* Misc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:helm-chart Airflow Helm Chart backport-to-chart/v1-2x-test Automatic backport to chart 1.2x maintenance branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants