Skip to content

Add workers.celery.extraVolumes & workers.kubernetes.extraVolumes#64746

Merged
jscheffl merged 6 commits intoapache:mainfrom
Miretpl:add-workers-celery-k8s-extra-volumes
Apr 10, 2026
Merged

Add workers.celery.extraVolumes & workers.kubernetes.extraVolumes#64746
jscheffl merged 6 commits intoapache:mainfrom
Miretpl:add-workers-celery-k8s-extra-volumes

Conversation

@Miretpl
Copy link
Copy Markdown
Contributor

@Miretpl Miretpl commented Apr 5, 2026

related: #28880

This PR introduces two new fields: workers.celery.extraVolumes and workers.kubernetes.extraVolumes. The workers.extraVolumes field is now deprecated.


Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@boring-cyborg boring-cyborg bot added the area:helm-chart Airflow Helm Chart label Apr 5, 2026
@Miretpl Miretpl force-pushed the add-workers-celery-k8s-extra-volumes branch from cf8a0d1 to 2a732e2 Compare April 7, 2026 21:52
@Miretpl Miretpl force-pushed the add-workers-celery-k8s-extra-volumes branch from 2a732e2 to 33f83ef Compare April 9, 2026 20:27
@Miretpl Miretpl force-pushed the add-workers-celery-k8s-extra-volumes branch from 33f83ef to bc09b57 Compare April 9, 2026 20:30
@Miretpl Miretpl marked this pull request as ready for review April 9, 2026 21:18
@Miretpl Miretpl marked this pull request as draft April 9, 2026 21:19
@Miretpl
Copy link
Copy Markdown
Contributor Author

Miretpl commented Apr 9, 2026

Missclicked on "Ready for review"

@Miretpl Miretpl marked this pull request as ready for review April 10, 2026 06:58
@kaxil kaxil requested a review from Copilot April 10, 2026 19:55
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@jscheffl jscheffl added the backport-to-chart/v1-2x-test Automatic backport to chart 1.2x maintenance branch label Apr 10, 2026
Copy link
Copy Markdown
Contributor

@jscheffl jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra-Volumes also smells very much like a good Kustomize Feature actually :-D

@jscheffl jscheffl merged commit 6cbf4c8 into apache:main Apr 10, 2026
108 of 110 checks passed
github-actions bot pushed a commit that referenced this pull request Apr 10, 2026
…es.extraVolumes (#64746)

* Seperate extraVolumes & extraVolumeMounts in values.yaml

* Refactor workers extraVolumes-related tests

* Add workers.celery.extraVolumes & workers.kubernetes.extraVolumes

* Add newsfragment
(cherry picked from commit 6cbf4c8)

Co-authored-by: Przemysław Mirowski <17602603+Miretpl@users.noreply.github.com>
@github-actions
Copy link
Copy Markdown
Contributor

Backport successfully created: chart/v1-2x-test

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

Status Branch Result
chart/v1-2x-test PR Link

@Miretpl
Copy link
Copy Markdown
Contributor Author

Miretpl commented Apr 10, 2026

I'm starting to think that basically everything with extra could be moved to Kustomize :D

@Miretpl Miretpl deleted the add-workers-celery-k8s-extra-volumes branch April 10, 2026 20:58
@jscheffl
Copy link
Copy Markdown
Contributor

I'm starting to think that basically everything with extra could be moved to Kustomize :D

Maybe 80% of these - pareto principly prbably applies here as well :-D (ExtraEnv is a pretty common thing for example... but I see potentially low coverage for extra containers on top of kerberos...

jscheffl pushed a commit that referenced this pull request Apr 10, 2026
…es.extraVolumes (#64746) (#65032)

* Seperate extraVolumes & extraVolumeMounts in values.yaml

* Refactor workers extraVolumes-related tests

* Add workers.celery.extraVolumes & workers.kubernetes.extraVolumes

* Add newsfragment
(cherry picked from commit 6cbf4c8)

Co-authored-by: Przemysław Mirowski <17602603+Miretpl@users.noreply.github.com>
@Miretpl
Copy link
Copy Markdown
Contributor Author

Miretpl commented Apr 10, 2026

Maybe 80% of these - pareto principly prbably applies here as well :-D (ExtraEnv is a pretty common thing for example... but I see potentially low coverage for extra containers on top of kerberos...

Agreed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:helm-chart Airflow Helm Chart backport-to-chart/v1-2x-test Automatic backport to chart 1.2x maintenance branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants