Skip to content

Improve Playwright test patterns in dag-calendar-tab #63409 #64747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
haseebmalik18 wants to merge 1 commit into from
Closed

Improve Playwright test patterns in dag-calendar-tab #63409 #64747

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 7 additions & 19 deletions airflow-core/src/airflow/ui/tests/e2e/pages/DagCalendarTab.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,10 +58,6 @@ export class DagCalendarTab extends BasePage {
return colors;
}

public async getActiveCellCount(): Promise<number> {
return this.activeCells.count();
}

public async getManualRunStates(): Promise<Array<string>> {
const count = await this.activeCells.count();
const states: Array<string> = [];
Expand All @@ -88,7 +84,7 @@ export class DagCalendarTab extends BasePage {
public async navigateToCalendar(dagId: string) {
await expect(async () => {
await this.safeGoto(`/dags/${dagId}/calendar`);
await this.page.getByTestId("dag-calendar-root").waitFor({ state: "visible", timeout: 5000 });
await expect(this.page.getByTestId("dag-calendar-root")).toBeVisible({ timeout: 5000 });
}).toPass({ intervals: [2000], timeout: 60_000 });
await this.waitForCalendarReady();
}
Expand All @@ -100,7 +96,7 @@ export class DagCalendarTab extends BasePage {
public async switchToHourly() {
await this.hourlyToggle.click();

await this.page.getByTestId("calendar-hourly-view").waitFor({ state: "visible", timeout: 30_000 });
await expect(this.page.getByTestId("calendar-hourly-view")).toBeVisible({ timeout: 30_000 });
}

public async switchToTotalView() {
Expand All @@ -112,22 +108,14 @@ export class DagCalendarTab extends BasePage {
}

private async waitForCalendarReady(): Promise<void> {
await this.page.getByTestId("dag-calendar-root").waitFor({ state: "visible", timeout: 120_000 });

await this.page.getByTestId("calendar-current-period").waitFor({ state: "visible", timeout: 120_000 });
await expect(this.page.getByTestId("dag-calendar-root")).toBeVisible({ timeout: 120_000 });

const overlay = this.page.getByTestId("calendar-loading-overlay");

if (await overlay.isVisible().catch(() => false)) {
await overlay.waitFor({ state: "hidden", timeout: 120_000 });
}
await expect(this.page.getByTestId("calendar-current-period")).toBeVisible({ timeout: 120_000 });

await this.page.getByTestId("calendar-grid").waitFor({ state: "visible", timeout: 120_000 });
await expect(this.page.getByTestId("calendar-loading-overlay")).toBeHidden({ timeout: 120_000 });

await this.page.waitForFunction(() => {
const cells = document.querySelectorAll('[data-testid="calendar-cell"]');
await expect(this.page.getByTestId("calendar-grid")).toBeVisible({ timeout: 120_000 });

return cells.length > 0;
});
await expect(this.calendarCells.first()).toBeVisible({ timeout: 120_000 });
}
}
10 changes: 3 additions & 7 deletions airflow-core/src/airflow/ui/tests/e2e/specs/dag-calendar-tab.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,9 +104,7 @@ test.describe("DAG Calendar Tab", () => {
test("verify active cells appear for DAG runs", async () => {
await calendar.switchToHourly();

const count = await calendar.getActiveCellCount();

expect(count).toBeGreaterThan(0);
await expect(calendar.activeCells.first()).toBeVisible();
});

test("verify manual runs are detected", async () => {
Expand Down Expand Up @@ -150,13 +148,11 @@ test.describe("DAG Calendar Tab", () => {
test("failed view reduces active cells", async () => {
await calendar.switchToHourly();

const totalCount = await calendar.getActiveCellCount();
const totalCount = await calendar.activeCells.count();

await calendar.switchToFailedView();

const failedCount = await calendar.getActiveCellCount();

expect(failedCount).toBeLessThan(totalCount);
await expect.poll(async () => calendar.activeCells.count(), { timeout: 10_000 }).toBeLessThan(totalCount);
});

test.fixme("color scale changes between total and failed view", async () => {
Expand Down
Loading