Skip to content

Clarify custom-time parameterized timetable logic (#34897)#69151

Merged
potiuk merged 1 commit into
apache:mainfrom
deepujain:fix-34897-parameterized-timetable
Jul 4, 2026
Merged

Clarify custom-time parameterized timetable logic (#34897)#69151
potiuk merged 1 commit into
apache:mainfrom
deepujain:fix-34897-parameterized-timetable

Conversation

@deepujain

@deepujain deepujain commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Title: Clarify custom-time parameterized timetable logic (#34897)

Summary

Clarify the parameterized timetable example so users know to compare the candidate time against their custom schedule_at value. The earlier midnight-specific rule from AfterWorkdayTimetable does not carry over once the run time is configurable.

Changes

  • airflow-core/docs/howto/timetable.rst -- add a short note explaining the same-day versus next-workday boundary for parameterized run times.

Test plan

  • git diff --check
  • prek run --stage pre-commit --files airflow-core/docs/howto/timetable.rst
  • CI passes
Was generative AI tooling used to co-author this PR?
  • Yes (OpenAI Codex)

Generated-by: OpenAI Codex following the guidelines

Fixes #34897

@shahar1 shahar1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deepujain please note that you (or your operator) should include AI attribution in the PR as we state in the AI guidelines.
This PR, as well as others, are blocked from being merged until this is corrected.
Please be warned that creating additional PRs except for the 10 you've already created (listed below) without addressing the above might cause in a permanent block from Apache organization on GitHub.

List of PRs:

@shahar1 shahar1 dismissed their stale review June 30, 2026 06:26

AI attribution addressed

@potiuk potiuk added the ready for maintainer review Set after triaging when all criteria pass. label Jul 2, 2026

@potiuk potiuk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs-only clarification of the custom-schedule timetable first-run logic — verified the diff, reads correctly. LGTM.

@potiuk potiuk added the backport-to-v3-3-test Backport to v3-3-test label Jul 4, 2026
@potiuk potiuk added this to the Airflow 3.3.1 milestone Jul 4, 2026
@potiuk potiuk merged commit a9f0cf5 into apache:main Jul 4, 2026
69 checks passed
@github-actions

github-actions Bot commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

Backport successfully created: v3-3-test

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

Status Branch Result
v3-3-test PR Link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-to-v3-3-test Backport to v3-3-test kind:documentation ready for maintainer review Set after triaging when all criteria pass.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect description on the implementation of parametrized timetables

3 participants