Skip to content

Commit 1faf9ab

Browse files
authored
feat!: remove go bigquery driver and Python, R packages (#4273)
Removes the Go BigQuery driver from the repo, including removing the Go driver source, all related testing and language-specific packaging (Python, R), and removing it from the documentation. Active development of the Go BigQuery driver has moved to https://github.com/adbc-drivers/bigquery and, as [posted](https://lists.apache.org/thread/goy9hfl5t0nj8hqvggb2wxssvh5n5yl3) on the Arrow dev mailing list and described in #4140 we can now remove the driver from this repo. The plan is to file follow-up PRs to better document the ecosystem, including how to use the new driver under the adbc-drivers org: #4233. Ref #4140
1 parent e1250f2 commit 1faf9ab

102 files changed

Lines changed: 18 additions & 11740 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.gitattributes

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ go/adbc/drivermgr/adbc_driver_manager_driver_loading.cc linguist-generated
2525
go/adbc/drivermgr/adbc_driver_manager_internal.h linguist-generated
2626
go/adbc/drivermgr/adbc_driver_manager_profiles.cc linguist-generated
2727
go/adbc/drivermgr/current_arch.h linguist-generated
28-
go/adbc/pkg/bigquery/* linguist-generated
2928
go/adbc/pkg/flightsql/* linguist-generated
3029
go/adbc/pkg/panicdummy/* linguist-generated
3130
go/adbc/pkg/snowflake/* linguist-generated

.github/workflows/native-unix.yml

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -263,11 +263,10 @@ jobs:
263263
meson test -C c/build --print-errorlogs
264264
- name: Build with sanitizers
265265
run: |
266-
# skip bigquery and flightsql for now; see GH-2744
266+
# skip flightsql for now; see GH-2744
267267
meson setup \
268268
-Db_sanitize=address,undefined \
269269
-Dauto_features=enabled \
270-
-Dbigquery=disabled \
271270
-Dflightsql=disabled \
272271
c c/build
273272
meson compile -C c/build
@@ -404,10 +403,6 @@ jobs:
404403
with:
405404
fetch-depth: 0
406405
persist-credentials: false
407-
- uses: google-github-actions/auth@7c6bc770dae815cd3e89ee6cdf493a5fab2cc093 # v3.0.0
408-
continue-on-error: true # if auth fails, bigquery driver tests should skip
409-
with:
410-
workload_identity_provider: ${{ secrets.GCP_WORKLOAD_IDENTITY_PROVIDER }}
411406
# XXX: https://github.com/actions/setup-go/issues/457
412407
# We can't use go-version-file for setup-go because it doesn't understand
413408
# the 'toolchain' parameter and staticcheck tends to need the latest Go
@@ -458,10 +453,6 @@ jobs:
458453
with:
459454
fetch-depth: 0
460455
persist-credentials: false
461-
- uses: google-github-actions/auth@7c6bc770dae815cd3e89ee6cdf493a5fab2cc093 # v3.0.0
462-
continue-on-error: true # if auth fails, bigquery driver tests should skip
463-
with:
464-
workload_identity_provider: ${{ secrets.GCP_WORKLOAD_IDENTITY_PROVIDER }}
465456
- name: Get required Go version
466457
run: |
467458
(. .env && echo "GO_VERSION=${GO}") >> $GITHUB_ENV

.github/workflows/native-windows.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,6 @@ jobs:
9696
env:
9797
BUILD_ALL: "1"
9898
# TODO(apache/arrow-adbc#634)
99-
BUILD_DRIVER_BIGQUERY: "0"
10099
BUILD_DRIVER_FLIGHTSQL: "0"
101100
BUILD_DRIVER_SNOWFLAKE: "0"
102101
BUILD_DRIVER_MANAGER_USER_CONFIG_TEST: "1"

.github/workflows/packaging.yml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -687,7 +687,6 @@ jobs:
687687
name: python-${{ matrix.arch }}-manylinux${{ matrix.manylinux_version }}
688688
retention-days: 7
689689
path: |
690-
adbc/python/adbc_driver_bigquery/repaired_wheels/*.whl
691690
adbc/python/adbc_driver_flightsql/repaired_wheels/*.whl
692691
adbc/python/adbc_driver_manager/repaired_wheels/*.whl
693692
adbc/python/adbc_driver_postgresql/repaired_wheels/*.whl
@@ -837,7 +836,6 @@ jobs:
837836
name: python-${{ matrix.arch }}-macos
838837
retention-days: 7
839838
path: |
840-
adbc/python/adbc_driver_bigquery/repaired_wheels/*.whl
841839
adbc/python/adbc_driver_flightsql/repaired_wheels/*.whl
842840
adbc/python/adbc_driver_manager/repaired_wheels/*.whl
843841
adbc/python/adbc_driver_postgresql/repaired_wheels/*.whl
@@ -1020,7 +1018,6 @@ jobs:
10201018
name: python${{ matrix.python_version }}-windows
10211019
retention-days: 7
10221020
path: |
1023-
adbc/python/adbc_driver_bigquery/repaired_wheels/*.whl
10241021
adbc/python/adbc_driver_flightsql/repaired_wheels/*.whl
10251022
adbc/python/adbc_driver_manager/repaired_wheels/*.whl
10261023
adbc/python/adbc_driver_postgresql/repaired_wheels/*.whl
@@ -1082,7 +1079,6 @@ jobs:
10821079
name: python-sdist
10831080
retention-days: 7
10841081
path: |
1085-
adbc/python/adbc_driver_bigquery/dist/*.tar.gz
10861082
adbc/python/adbc_driver_flightsql/dist/*.tar.gz
10871083
adbc/python/adbc_driver_manager/dist/*.tar.gz
10881084
adbc/python/adbc_driver_postgresql/dist/*.tar.gz

.github/workflows/r-basic.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ jobs:
5353
strategy:
5454
matrix:
5555
os: [ubuntu]
56-
pkg: [adbcflightsql, adbcsnowflake, adbcbigquery]
56+
pkg: [adbcflightsql, adbcsnowflake]
5757

5858
uses: ./.github/workflows/r-check.yml
5959
with:

.github/workflows/r-extended.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ jobs:
6161
matrix:
6262
rversion: [oldrel, release, devel]
6363
os: [macOS, windows, ubuntu]
64-
pkg: [adbcflightsql, adbcsnowflake, adbcbigquery]
64+
pkg: [adbcflightsql, adbcsnowflake]
6565
max-parallel: 5
6666
fail-fast: false
6767

.github/workflows/r-standard.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ jobs:
6262
strategy:
6363
matrix:
6464
os: [ubuntu, macOS, windows]
65-
pkg: [adbcflightsql, adbcsnowflake, adbcbigquery]
65+
pkg: [adbcflightsql, adbcsnowflake]
6666

6767
uses: ./.github/workflows/r-check.yml
6868
with:

.github/workflows/rust.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,6 @@ jobs:
128128
pushd build
129129
cmake \
130130
-DADBC_BUILD_TESTS=OFF \
131-
-DADBC_DRIVER_BIGQUERY=ON \
132131
-DADBC_DRIVER_FLIGHTSQL=ON \
133132
-DADBC_DRIVER_MANAGER=ON \
134133
-DADBC_DRIVER_SQLITE=ON \

LICENSE.txt

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -424,12 +424,6 @@ cloud.google.com/go/auth/oauth2adapt is under the Apache-2.0 license.
424424

425425
--------------------------------------------------------------------------------
426426

427-
3rdparty dependency cloud.google.com/go/bigquery
428-
is statically linked in certain binary distributions, like the Python wheels.
429-
cloud.google.com/go/bigquery is under the Apache-2.0 license.
430-
431-
--------------------------------------------------------------------------------
432-
433427
3rdparty dependency cloud.google.com/go/compute/metadata
434428
is statically linked in certain binary distributions, like the Python wheels.
435429
cloud.google.com/go/compute/metadata is under the Apache-2.0 license.

c/CMakeLists.txt

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -95,12 +95,6 @@ if(ADBC_DRIVER_SNOWFLAKE)
9595
add_subdirectory(driver/snowflake)
9696
endif()
9797

98-
if(ADBC_DRIVER_BIGQUERY)
99-
install(FILES "${REPOSITORY_ROOT}/c/include/arrow-adbc/driver/bigquery.h"
100-
DESTINATION include/arrow-adbc/driver)
101-
add_subdirectory(driver/bigquery)
102-
endif()
103-
10498
if(ADBC_INTEGRATION_DUCKDB)
10599
add_subdirectory(integration/duckdb)
106100
endif()
@@ -151,10 +145,6 @@ LIBRARY=$<TARGET_FILE:adbc_driver_${TARGET}_shared>" ${Python3_EXECUTABLE} -m pi
151145
if(ADBC_DRIVER_SNOWFLAKE)
152146
adbc_install_python_package(snowflake)
153147
endif()
154-
155-
if(ADBC_DRIVER_BIGQUERY)
156-
adbc_install_python_package(bigquery)
157-
endif()
158148
endif()
159149

160150
validate_config()

0 commit comments

Comments
 (0)