remove redudant readonly user agent

toddmeng-db · toddmeng-db · commit 9c6119be3b9a · 2025-04-21T23:55:36.000-07:00
diff --git a/csharp/src/Drivers/Apache/Spark/SparkHttpConnection.cs b/csharp/src/Drivers/Apache/Spark/SparkHttpConnection.cs
@@ -35,7 +35,6 @@ namespace Apache.Arrow.Adbc.Drivers.Apache.Spark
 {
     internal class SparkHttpConnection : SparkConnection
     {
-        private static readonly string s_baseUserAgent = $"{DriverName.Replace(" ", "")}/{ProductVersionDefault}";
         private const string BasicAuthenticationScheme = "Basic";
         private const string BearerAuthenticationScheme = "Bearer";
 
@@ -258,7 +257,7 @@ private string GetUserAgent()
             // Build the base user agent string with Thrift version
             string thriftVersion = GetThriftVersion();
             string thriftComponent = string.IsNullOrEmpty(thriftVersion) ? "Thrift" : $"Thrift/{thriftVersion}";
-            string baseUserAgent = $"{DriverName.Replace(" ", "")}/{ProductVersionDefault} {thriftComponent}"; // consider using ProductVersion instead of ProductVersionDefault
+            string baseUserAgent = $"{DriverName.Replace(" ", "")}/{ProductVersion} {thriftComponent}";
             
             // Check if a client has provided a user-agent entry
             if (Properties.TryGetValue(SparkParameters.UserAgentEntry, out string? userAgentEntry) && !string.IsNullOrWhiteSpace(userAgentEntry))

Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,6 @@ namespace Apache.Arrow.Adbc.Drivers.Apache.Spark`
`35`	`35`	`{`
`36`	`36`	`internal class SparkHttpConnection : SparkConnection`
`37`	`37`	`{`
`38`		`- private static readonly string s_baseUserAgent = $"{DriverName.Replace(" ", "")}/{ProductVersionDefault}";`
`39`	`38`	`private const string BasicAuthenticationScheme = "Basic";`
`40`	`39`	`private const string BearerAuthenticationScheme = "Bearer";`
`41`	`40`
`@@ -258,7 +257,7 @@ private string GetUserAgent()`
`258`	`257`	`// Build the base user agent string with Thrift version`
`259`	`258`	`string thriftVersion = GetThriftVersion();`
`260`	`259`	`string thriftComponent = string.IsNullOrEmpty(thriftVersion) ? "Thrift" : $"Thrift/{thriftVersion}";`
`261`		`- string baseUserAgent = $"{DriverName.Replace(" ", "")}/{ProductVersionDefault} {thriftComponent}"; // consider using ProductVersion instead of ProductVersionDefault`
	`260`	`+ string baseUserAgent = $"{DriverName.Replace(" ", "")}/{ProductVersion} {thriftComponent}";`
`262`	`261`
`263`	`262`	`// Check if a client has provided a user-agent entry`
`264`	`263`	`if (Properties.TryGetValue(SparkParameters.UserAgentEntry, out string? userAgentEntry) && !string.IsNullOrWhiteSpace(userAgentEntry))`