Skip to content

ci: analyze workflows with zizmor#4270

Merged
lidavidm merged 1 commit into
apache:mainfrom
lidavidm:zizmor
Apr 28, 2026
Merged

ci: analyze workflows with zizmor#4270
lidavidm merged 1 commit into
apache:mainfrom
lidavidm:zizmor

Conversation

@lidavidm

Copy link
Copy Markdown
Member
  • Add cooldowns to dependabot.yml
  • Pin actions
  • Use environment variables instead of directly expanding variables into shell blocks
  • Disable caching in packaging.yml since this builds binaries
  • Add some missing permissions and concurrency blocks

@lidavidm
lidavidm requested review from amoeba, kou and zeroshade April 27, 2026 02:11
@lidavidm

Copy link
Copy Markdown
Member Author

There's some followup work, but I believe both of our cmd.exe blocks are safe (they use cmd.exe for vcvarsall.bat but presumably that can be done in PowerShell too): #4269

@lidavidm

Copy link
Copy Markdown
Member Author

I'm following iceberg-cpp, which also uses CodeQL. I haven't setup CodeQL here.
https://github.com/apache/iceberg-cpp/pull/618/files#diff-12783128521e452af0cfac94b99b8d250413c516ec71fe6d97dbea666ff7ba27

@lidavidm

Copy link
Copy Markdown
Member Author

I think I'll suppress secrets-outside-env for now. Many of those secrets will be removed soon once @amoeba finishes #4140.

@lidavidm

Copy link
Copy Markdown
Member Author

It appears the .NET error was already there.

@lidavidm
lidavidm marked this pull request as ready for review April 27, 2026 05:40

@amoeba amoeba left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread .github/workflows/asf-allowlist-check.yml Outdated
Comment thread .github/workflows/packaging.yml
Comment thread .github/workflows/packaging.yml
Comment thread .github/workflows/packaging.yml
@lidavidm
lidavidm merged commit 21f1704 into apache:main Apr 28, 2026
202 of 207 checks passed
@lidavidm
lidavidm deleted the zizmor branch April 28, 2026 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants