chore!(rust): remove DataFusion driver#4455
Conversation
|
CC @eitsupi |
| @@ -244,7 +227,7 @@ jobs: | |||
| -p arrow-schema \ | |||
| -p arrow-select | |||
|
|
|||
| # If the lock file was updated, run the tests except for adbc_datafusion | |||
| # If the lock file was updated, run the tests | |||
| if ! git diff --quiet Cargo.lock; then | |||
| cargo test --all-targets --all-features --workspace --exclude adbc_datafusion | |||
| cargo test --all-targets --all-features --workspace | |||
| fi | |||
There was a problem hiding this comment.
The purpose of this test is to test the case where Cargo.lock does not point to the latest arrow due to constraints imposed by Datafusion, so it can probably be removed.
There was a problem hiding this comment.
Hmm, ideally we can still test with an older version of Arrow though
There was a problem hiding this comment.
Ah, but you have that test already with minimal-versions. Got it.
There was a problem hiding this comment.
Of course, there's still the advantage of testing for the latest arrow immediately before Dependabot updating the lock file, so it might be worth keeping (although it could be annoying if it suddenly starts failing).
lidavidm
force-pushed
the
remove-datafusion
branch
from
c69965f to
7751791
Compare
|
|
||
| .. _DataFusion: https://datafusion.apache.org/ | ||
|
|
||
| .. note:: The DataFusion driver is maintained by a third party. We're using it here since we don't maintain any Rust-based drivers directly. |
There was a problem hiding this comment.
| .. note:: The DataFusion driver is maintained by a third party. We're using it here since we don't maintain any Rust-based drivers directly. | |
| .. note:: The DataFusion driver is maintained by a third party, the ADBC Driver Foundry (https://adbc-drivers.org). We're using it here since we don't maintain any Rust-based drivers directly. |
|
I updated the PR body to link to the new repo instead of just saying "a third party". |
3 participants
Maintenance of this driver has moved to https://github.com/adbc-drivers/datafusion. Additionally, this makes it easier to deal with dependency upgrades (DataFusion tends to lag behind a bit).