-
Notifications
You must be signed in to change notification settings - Fork 189
ci: verify source using OS-installed dependencies #2718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,111 @@ | ||
| #!/bin/bash | ||
| # | ||
| # Licensed to the Apache Software Foundation (ASF) under one | ||
| # or more contributor license agreements. See the NOTICE file | ||
| # distributed with this work for additional information | ||
| # regarding copyright ownership. The ASF licenses this file | ||
| # to you under the Apache License, Version 2.0 (the | ||
| # "License"); you may not use this file except in compliance | ||
| # with the License. You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, | ||
| # software distributed under the License is distributed on an | ||
| # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| # KIND, either express or implied. See the License for the | ||
| # specific language governing permissions and limitations | ||
| # under the License. | ||
| # | ||
|
|
||
| # Test the validation script using system dependencies instead of Conda. This | ||
| # script is meant for automation (e.g. Docker), not a local/developer machine | ||
| # (except via Docker). | ||
|
|
||
| set -euo pipefail | ||
|
|
||
| main() { | ||
| local -r source_dir="${1}" | ||
|
|
||
| # Install all the dependencies we need for all the subprojects | ||
|
|
||
| # When installing tzdata, don't block and wait for user input | ||
| export DEBIAN_FRONTEND=noninteractive | ||
| export TZ=Etc/UTC | ||
|
|
||
| apt update | ||
| apt install -y \ | ||
| apt-transport-https \ | ||
| build-essential \ | ||
| ca-certificates \ | ||
| cmake \ | ||
| curl \ | ||
| dirmngr \ | ||
| git \ | ||
| gobject-introspection \ | ||
| gpg \ | ||
| libgirepository1.0-dev \ | ||
| libglib2.0-dev \ | ||
| libgmock-dev \ | ||
| libgtest-dev \ | ||
| libpq-dev \ | ||
| libsqlite3-dev \ | ||
| lsb-release \ | ||
| ninja-build \ | ||
| pkg-config \ | ||
| protobuf-compiler \ | ||
| python3 \ | ||
| python3-dev \ | ||
| python3-pip \ | ||
| python3-venv \ | ||
| r-base \ | ||
| ruby-full \ | ||
| software-properties-common \ | ||
| wget | ||
|
|
||
| # Install Java | ||
|
|
||
| wget -qO - https://packages.adoptium.net/artifactory/api/gpg/key/public | \ | ||
| gpg --dearmor | \ | ||
| tee /etc/apt/trusted.gpg.d/adoptium.gpg > /dev/null | ||
|
|
||
| echo "deb https://packages.adoptium.net/artifactory/deb $(awk -F= '/^VERSION_CODENAME/{print$2}' /etc/os-release) main" | \ | ||
| tee /etc/apt/sources.list.d/adoptium.list | ||
|
|
||
| # Install Arrow GLib | ||
| wget https://packages.apache.org/artifactory/arrow/$(lsb_release --id --short | tr 'A-Z' 'a-z')/apache-arrow-apt-source-latest-$(lsb_release --codename --short).deb | ||
| apt install -y -V ./apache-arrow-apt-source-latest-$(lsb_release --codename --short).deb | ||
|
|
||
| apt update | ||
| apt install -y \ | ||
| libarrow-dev \ | ||
| libarrow-glib-dev \ | ||
| temurin-21-jdk | ||
|
|
||
| # Install Maven | ||
| wget https://dlcdn.apache.org/maven/maven-3/3.9.9/binaries/apache-maven-3.9.9-bin.tar.gz | ||
| mkdir -p /opt/maven | ||
| tar -C /opt/maven -xzvf apache-maven-3.9.9-bin.tar.gz --strip-components=1 | ||
| export PATH=/opt/maven/bin:$PATH | ||
|
|
||
| # Check if protoc is too old (Ubuntu 22.04). If so, install it from | ||
| # upstream instead. | ||
| if ! protoc --version | \ | ||
| awk '{print $2}{print "3.15"}' | \ | ||
| sort --version-sort | \ | ||
| head -n1 | \ | ||
| grep -E '^3\.15.*$' >/dev/null ; then | ||
| echo "protoc is too old" | ||
|
|
||
| wget -O protoc.zip https://github.com/protocolbuffers/protobuf/releases/download/v30.2/protoc-30.2-linux-x86_64.zip | ||
| unzip -o protoc.zip -d /usr/local -x readme.txt | ||
| fi | ||
|
|
||
| # We run under Docker and this is necessary since the source dir is | ||
| # typically mounted as a volume | ||
| git config --global --add safe.directory "${source_dir}" | ||
|
|
||
| "${source_dir}/dev/release/verify-release-candidate.sh" | ||
| } | ||
|
|
||
| main "$@" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -246,38 +246,42 @@ install_dotnet() { | |
| return 0 | ||
| fi | ||
|
|
||
| show_info "Ensuring that .NET is installed..." | ||
|
|
||
| if dotnet --version | grep 8\.0 > /dev/null 2>&1; then | ||
| local csharp_bin=$(dirname $(which dotnet)) | ||
| show_info "Found C# at $(which csharp) (.NET $(dotnet --version))" | ||
| else | ||
| if which dotnet > /dev/null 2>&1; then | ||
| show_info "dotnet found but it is the wrong version and will be ignored." | ||
| if command -v dotnet; then | ||
| show_info "Found $(dotnet --version) at $(which dotnet)" | ||
|
|
||
| if dotnet --version | grep --quiet --fixed-string 8.0; then | ||
| local csharp_bin=$(dirname $(which dotnet)) | ||
| show_info "Found C# at $(which csharp) (.NET $(dotnet --version))" | ||
| DOTNET_ALREADY_INSTALLED=1 | ||
| return 0 | ||
| fi | ||
| local csharp_bin=${ARROW_TMPDIR}/csharp/bin | ||
| local dotnet_version=8.0.204 | ||
| local dotnet_platform= | ||
| case "$(uname)" in | ||
| fi | ||
|
|
||
| show_info "dotnet found but it is the wrong version or dotnet not found" | ||
|
|
||
| local csharp_bin=${ARROW_TMPDIR}/csharp/bin | ||
| local dotnet_version=8.0.204 | ||
| local dotnet_platform= | ||
| case "$(uname)" in | ||
| Linux) | ||
| dotnet_platform=linux | ||
| ;; | ||
| dotnet_platform=linux | ||
| ;; | ||
| Darwin) | ||
| dotnet_platform=macos | ||
| ;; | ||
| esac | ||
| local dotnet_download_thank_you_url=https://dotnet.microsoft.com/download/thank-you/dotnet-sdk-${dotnet_version}-${dotnet_platform}-x64-binaries | ||
| local dotnet_download_url=$( \ | ||
| curl -sL ${dotnet_download_thank_you_url} | \ | ||
| grep 'directLink' | \ | ||
| grep -E -o 'https://download[^"]+' | \ | ||
| sed -n 2p) | ||
| mkdir -p ${csharp_bin} | ||
| curl -sL ${dotnet_download_url} | \ | ||
| dotnet_platform=macos | ||
| ;; | ||
| esac | ||
| local dotnet_download_thank_you_url=https://dotnet.microsoft.com/download/thank-you/dotnet-sdk-${dotnet_version}-${dotnet_platform}-x64-binaries | ||
| show_info "Getting .NET download URL from ${dotnet_download_thank_you_url}" | ||
|
Comment on lines
+273
to
+274
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I appreciate the politeness exuded by dotnet's download URL 🙂 |
||
| local dotnet_download_url=$(curl -sL ${dotnet_download_thank_you_url} | \ | ||
| grep 'directLink' | \ | ||
| grep -E -o 'https://download[^"]+' | \ | ||
| sed -n 2p) | ||
| show_info "Downloading .NET from ${dotnet_download_url}" | ||
| mkdir -p ${csharp_bin} | ||
| curl -sL ${dotnet_download_url} | \ | ||
| tar xzf - -C ${csharp_bin} | ||
| PATH=${csharp_bin}:${PATH} | ||
| show_info "Installed C# at $(which csharp) (.NET $(dotnet --version))" | ||
| fi | ||
| PATH=${csharp_bin}:${PATH} | ||
| show_info "Installed C# at $(which csharp) (.NET $(dotnet --version))" | ||
|
|
||
| DOTNET_ALREADY_INSTALLED=1 | ||
| } | ||
|
|
@@ -296,6 +300,18 @@ install_go() { | |
| return 0 | ||
| fi | ||
|
|
||
| local prefix=${ARROW_TMPDIR}/go | ||
| mkdir -p $prefix | ||
|
|
||
| if [ -f "${prefix}/go/bin/go" ]; then | ||
| export GOROOT=${prefix}/go | ||
| export GOPATH=${prefix}/gopath | ||
| export PATH=$GOROOT/bin:$GOPATH/bin:$PATH | ||
| show_info "Found $(go version) at ${prefix}/go/bin/go" | ||
| GO_ALREADY_INSTALLED=1 | ||
| return 0 | ||
| fi | ||
|
|
||
| local version=1.24.2 | ||
| show_info "Installing go version ${version}..." | ||
|
|
||
|
|
@@ -315,8 +331,6 @@ install_go() { | |
| local archive="go${version}.${os}-${arch}.tar.gz" | ||
| curl -sLO https://go.dev/dl/$archive | ||
|
|
||
| local prefix=${ARROW_TMPDIR}/go | ||
| mkdir -p $prefix | ||
| tar -xzf $archive -C $prefix | ||
| rm -f $archive | ||
|
|
||
|
|
@@ -549,7 +563,7 @@ test_python() { | |
| show_header "Build and test Python libraries" | ||
|
|
||
| # Build and test Python | ||
| maybe_setup_virtualenv cython duckdb pandas protobuf pyarrow pytest setuptools_scm setuptools importlib_resources || exit 1 | ||
| maybe_setup_virtualenv cython duckdb pandas polars protobuf pyarrow pytest setuptools_scm setuptools importlib_resources || exit 1 | ||
| # XXX: pin Python for now since various other packages haven't caught up | ||
| maybe_setup_conda --file "${ADBC_DIR}/ci/conda_env_python.txt" python=3.12 || exit 1 | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow! I didn't know
@U!