fix(c): enable linking to static builds by lidavidm · Pull Request #2738 · apache/arrow-adbc

lidavidm · 2025-04-23T07:53:48Z

Correct a typo that was causing CMake to look for the shared library instead of the static library.
Fix CMake looking for the static library in the wrong place.
Test that linking against the static library works.
Test that linking with system-provided fmt/nanoarrow works.
Test that linking against multiple static drivers works.
Add headers to provide the entrypoint for static drivers.
Add build option to disable generation of shared Adbc* functions.
Respect this option from Go drivers too.
Namespace the functions inside adbc_driver_common (things like SetError appear to be leaking out)
Namespace the SQLite driver functions (e.g. StatementReaderUpcastInt64ToDouble)
Add static linking documentation.

Fixes #2562.

kou

Could you remove *~ files?

lidavidm · 2025-04-23T08:02:21Z

Thanks, I need to get my global .gitignore back on this new machine...

WillAyd

lgtm. FWIW another way to test this would be to leverage the meson configuration to produce static libraries:

meson setup builddir -Ddefault_library=static ...

That would save you from having to mess around with any configuration files, although I'm guessing the CMake changes are for downstream CMake projects anyway

lidavidm · 2025-04-23T14:24:25Z

Yup, the CMake fixes are to make it actually work with CMake 😅

This still isn't building FWIW - I need to get adbc_driver_common exported properly

WillAyd · 2025-04-24T12:16:46Z

+# applications can link to it
+if(ADBC_BUILD_STATIC)
+  if(ADBC_WITH_VENDORED_NANOARROW)
+    message(WARNING "adbc_driver_common is not installed when ADBC_WITH_VENDORED_NANOARROW is ON. To use the static libraries, for now you must provide nanoarrow instead of using the vendored copy"


What is the problem with installing in this case?

I am guessing that it would install/require the headers and ADBC should probably not be installing headers for nanoarrow/?

Yeah, I tried to install Nanoarrow but CMake failed because of something about the header not being installable - decided to punt since to start with I don't think we need to support every possible case.

WillAyd · 2025-04-24T12:19:33Z

 static size_t kErrorBufferSize = 1024;

-int AdbcStatusCodeToErrno(AdbcStatusCode code) {
+int PrivateAdbcStatusCodeToErrno(AdbcStatusCode code) {


Nit but maybe this would be better to call Internal instead of Private just to keep in sync with the arrow repo? I know upstream there is even some confusion over the different namespace terminology apache/arrow#45808

Ah, I can change it. I saw for Nanoarrow we used the 'Private' prefix which is why I went with that

lidavidm · 2025-04-25T06:29:20Z

Ok, I think everything is working here now...more changes than I expected

lidavidm · 2025-04-28T13:29:55Z

@WillAyd @kou any comments here?

WillAyd · 2025-04-28T13:27:45Z

+
+#pragma once
+
+#ifndef ADBC_DRIVER_BIGQUERY_H


Since we already have #pragma once can we get rid of the manual include guard? Should help simplify the macro usage

WillAyd

lgtm

kou

+1

kou · 2025-04-28T22:50:10Z

+#endif
+
+ADBC_EXPORT
+AdbcStatusCode BigQueryDriverInit(int version, void* raw_driver, struct AdbcError* error);


We may want to add Adbc prefix for *DriverInit() functions:

Suggested change

AdbcStatusCode BigQueryDriverInit(int version, void* raw_driver, struct AdbcError* error);

AdbcStatusCode AdbcBigQueryDriverInit(int version, void* raw_driver, struct AdbcError* error);

From adbc.h it seems this should be AdbcDriverBigqueryInit. I'll make sure these are consistent.

I've updated all of these. I've retained the old names for backwards compatibility.

lidavidm · 2025-05-09T11:55:17Z

Any more comments here?

Fixes apache#2562.

Co-authored-by: Sutou Kouhei <kou@cozmixng.org>

kou reviewed Apr 23, 2025

View reviewed changes

lidavidm force-pushed the gh-2562 branch from c6e6cbd to fa1a83b Compare April 23, 2025 08:02

lidavidm force-pushed the gh-2562 branch 3 times, most recently from 00d8509 to 148dd20 Compare April 23, 2025 14:08

WillAyd approved these changes Apr 23, 2025

View reviewed changes

lidavidm force-pushed the gh-2562 branch 4 times, most recently from 5c1f2ca to 854a8ee Compare April 24, 2025 03:59

lidavidm mentioned this pull request Apr 24, 2025

Drivers are unusable when statically linked with CMake #2562

Closed

lidavidm marked this pull request as ready for review April 24, 2025 08:25

lidavidm requested a review from zeroshade as a code owner April 24, 2025 08:25

github-actions Bot added this to the ADBC Libraries 18 milestone Apr 24, 2025

lidavidm force-pushed the gh-2562 branch 3 times, most recently from b4624e6 to 5941015 Compare April 24, 2025 09:46

WillAyd reviewed Apr 24, 2025

View reviewed changes

lidavidm mentioned this pull request Apr 28, 2025

feat(c): Use C++ visibility support in Meson configuration #2740

Open

WillAyd reviewed Apr 28, 2025

View reviewed changes

WillAyd approved these changes Apr 28, 2025

View reviewed changes

kou approved these changes Apr 29, 2025

View reviewed changes

lidavidm force-pushed the gh-2562 branch from fbc7fba to 0d91cc9 Compare April 29, 2025 06:10

lidavidm requested review from CurtHagenlocher and wjones127 as code owners April 29, 2025 07:54

lidavidm removed this from the ADBC Libraries 18 milestone May 3, 2025

lidavidm added this to the ADBC Libraries 19 milestone May 3, 2025

lidavidm and others added 16 commits May 19, 2025 10:27

fix(c): enable linking to static builds

9099023

Fixes apache#2562.

PrivateAdbc -> InternalAdbc

34f66d9

Namespace SQLite internals

394f1ab

Namespace common internals

48a93a5

Add headers for entrypoints

fc0aa11

Fix typo in path

c3003bc

fix python-debug

f1304f2

fix python-debug (for real!?)

af5bbd5

Remove redundant include guard

7f8bfba

Apply suggestions from code review

6bb1dda

Co-authored-by: Sutou Kouhei <kou@cozmixng.org>

fix

74a7dc5

can't have quotes with generator expression

92ce999

rename to be consistent

35d1fb7

fix names

7ecc1ec

fix names

d3c1d53

more renaming, add alias for compatibility

87ad465

lidavidm force-pushed the gh-2562 branch from 9ed84c7 to 87ad465 Compare May 19, 2025 01:27

lidavidm merged commit 19ff899 into apache:main May 19, 2025
99 of 101 checks passed

lidavidm deleted the gh-2562 branch May 19, 2025 02:07

howareyouman mentioned this pull request Jun 27, 2025

Function FlightSQLDriverInit is not found #3055

Closed

serramatutu mentioned this pull request Aug 12, 2025

Sync upstream dbt-labs/arrow-adbc#52

Closed

	AdbcStatusCode BigQueryDriverInit(int version, void* raw_driver, struct AdbcError* error);
	AdbcStatusCode AdbcBigQueryDriverInit(int version, void* raw_driver, struct AdbcError* error);


		#pragma once

		#ifndef ADBC_DRIVER_BIGQUERY_H

Conversation

lidavidm commented Apr 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kou left a comment

Choose a reason for hiding this comment

Uh oh!

lidavidm commented Apr 23, 2025

Uh oh!

WillAyd left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lidavidm commented Apr 23, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

lidavidm commented Apr 25, 2025

Uh oh!

lidavidm commented Apr 28, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

WillAyd left a comment

Choose a reason for hiding this comment

Uh oh!

kou left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lidavidm Apr 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

lidavidm commented May 9, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

lidavidm commented Apr 23, 2025 •

edited

Loading

WillAyd left a comment •

edited

Loading

lidavidm Apr 29, 2025 •

edited

Loading