test(java/driver/jni): add tests with drivers besides SQLite#4235
Merged
lidavidm merged 1 commit intoapache:mainfrom Apr 22, 2026
Merged
test(java/driver/jni): add tests with drivers besides SQLite#4235lidavidm merged 1 commit intoapache:mainfrom
lidavidm merged 1 commit intoapache:mainfrom
Conversation
lidavidm
force-pushed
the
gh-4230
branch
7 times, most recently
from
014ec6e to
f3144b5
Compare
zeroshade
approved these changes
Apr 22, 2026
Member
zeroshade
left a comment
zeroshade
left a comment
There was a problem hiding this comment.
Nothing particularly stands out to me other than one nitpick question. Looks good!
Comment on lines
+242
to
+252
| wget https://dbc-cdn.columnar.tech/mssql/v1.3.1/mssql_linux_amd64_v1.3.1.tar.gz | ||
| echo "e6723cf417403f313fb75c1ac03aea9b9ff857d4a947608c8ae44eacc1aa22b3 mssql_linux_amd64_v1.3.1.tar.gz" > mssql_linux_amd64_v1.3.1.tar.gz.sha256 | ||
| sha256sum -c mssql_linux_amd64_v1.3.1.tar.gz.sha256 | ||
|
|
||
| tar xvf mssql_linux_amd64_v1.3.1.tar.gz | ||
| mkdir -p ~/.config/adbc/drivers/ | ||
| mv libadbc_driver_mssql.so ~/.config/adbc/drivers/ | ||
| echo "manifest_version = 1" > ~/.config/adbc/drivers/mssql.toml | ||
| echo "[Driver]" >> ~/.config/adbc/drivers/mssql.toml | ||
| echo "shared = '$HOME/.config/adbc/drivers/libadbc_driver_mssql.so'" >> ~/.config/adbc/drivers/mssql.toml | ||
| cat ~/.config/adbc/drivers/mssql.toml |
Member
Author
There was a problem hiding this comment.
Nah, I'm trying to minimize external dependencies here. Also I want to pin a particular hash since it's an external binary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4230.