feat(java/driver/jni): implement executePartitioned#4263
Merged
lidavidm merged 1 commit intoapache:mainfrom Apr 27, 2026
Merged
feat(java/driver/jni): implement executePartitioned#4263lidavidm merged 1 commit intoapache:mainfrom
lidavidm merged 1 commit intoapache:mainfrom
Conversation
zeroshade
requested changes
Apr 24, 2026
Member
zeroshade
left a comment
zeroshade
left a comment
There was a problem hiding this comment.
LGTM, just the same nitpicks
| JNIEnv* env, [[maybe_unused]] jclass self, jlong handle) { | ||
| struct AdbcError error = ADBC_ERROR_INIT; | ||
| auto* ptr = reinterpret_cast<struct AdbcStatement*>(static_cast<uintptr_t>(handle)); | ||
| struct ArrowSchema schema = {}; |
Member
There was a problem hiding this comment.
same as elsewhere, drop this since it's unused?
| JNIEnv* env, [[maybe_unused]] jclass self, jlong handle) { | ||
| struct AdbcError error = ADBC_ERROR_INIT; | ||
| auto* ptr = reinterpret_cast<struct AdbcConnection*>(static_cast<uintptr_t>(handle)); | ||
| struct ArrowSchema schema = {}; |
Member
There was a problem hiding this comment.
same as elsewhere, drop since unused?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4262.