chore!(rust): remove DataFusion driver#4455
Open
lidavidm wants to merge 1 commit into
Open
Conversation
Member
Author
|
CC @eitsupi |
eitsupi
reviewed
Jul 2, 2026
Comment on lines
219
to
233
| @@ -244,7 +227,7 @@ jobs: | |||
| -p arrow-schema \ | |||
| -p arrow-select | |||
|
|
|||
| # If the lock file was updated, run the tests except for adbc_datafusion | |||
| # If the lock file was updated, run the tests | |||
| if ! git diff --quiet Cargo.lock; then | |||
| cargo test --all-targets --all-features --workspace --exclude adbc_datafusion | |||
| cargo test --all-targets --all-features --workspace | |||
| fi | |||
Contributor
There was a problem hiding this comment.
The purpose of this test is to test the case where Cargo.lock does not point to the latest arrow due to constraints imposed by Datafusion, so it can probably be removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maintenance of this driver has moved to a third party. Additionally, this makes it easier to deal with dependency upgrades (DataFusion tends to lag behind a bit).