fix(arrow/array): fix concat for out of order REE slices#587
Merged
Conversation
Member
Author
lidavidm
approved these changes
Dec 2, 2025
| buf.WriteByte('[') | ||
| for i := 0; i < r.ends.Len(); i++ { | ||
| if i != 0 { | ||
| for i := physOffset; i < physOffset+physLength; i++ { |
Member
There was a problem hiding this comment.
nit: any reason we can't use the new i := range physOffset+physLength?
Member
Author
There was a problem hiding this comment.
we're not starting at 0, we're starting at physOffset.
We could do i := range physLength and then do offset := i + physOffset inside the loop, but I felt that wasn't as obvious and easily missed as opposed to explicitly going from physOffset to physOffset + physLength
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
fixes #562
What changes are included in this PR?
Fixing a bug in
Concatenatefor REE slices where the first slice has a non-zero offsetAre these changes tested?
Yes, a unit test is added for this scenario
Are there any user-facing changes?
Only the bug fix