fix(avro): error on complex (non-nullable) unions instead of silently dropping (#777)#808
Open
SAY-5 wants to merge 1 commit into
Open
fix(avro): error on complex (non-nullable) unions instead of silently dropping (#777)#808SAY-5 wants to merge 1 commit into
SAY-5 wants to merge 1 commit into
Conversation
… dropping (apache#777) Signed-off-by: SAY-5 <saiasish.cnp@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Fixes #777.
ArrowSchemaFromAvropreviously silently dropped non-nullable Avro unions (e.g.["int","string"]) in botharrowSchemafromAvroanditerateFields. Output schemas were missing fields with no warning to the caller.What changes are included in this PR?
Panic with a clear error message at the two
case "union"/case *avro.UnionSchemaarms when the union is not a simple nullable. The package's existingrecover()inArrowSchemaFromAvroconverts this into a returned error.Are these changes tested?
Yes,
TestComplexUnionReportsErrorexercises a record with["int","string"]and asserts a non-nil error mentioningunion.Are there any user-facing changes?
Callers that previously received an incomplete schema for a complex-union field now get an explicit error.