fix(ipc): preserve map child field metadata#809
Open
dimakuz wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
IPC deserialization of
MapTypereconstructed map key/value children from only their data types, which dropped field-level metadata on the key and value fields. This could silently lose metadata such as field IDs after an IPC schema round-trip.What changes are included in this PR?
The IPC metadata reader now reconstructs
MapTypeusingarrow.MapOfFields(...)with the already-deserialized key and value fields, preserving their metadata and nullability.A regression test was added to verify that map key/value field metadata, item nullability, and
KeysSortedsurvive an IPC schema round-trip.Are these changes tested?
Yes - unit test included.
Are there any user-facing changes?
Yes - IPC schema deserialization now preserves field-level metadata on MapType key and value children.