Skip to content

[minor] remove unused macro definition#685

Closed
dentiny wants to merge 1 commit into
apache:mainfrom
dentiny:hjiang/remove-unused-macro-def
Closed

[minor] remove unused macro definition#685
dentiny wants to merge 1 commit into
apache:mainfrom
dentiny:hjiang/remove-unused-macro-def

Conversation

@dentiny

@dentiny dentiny commented Apr 7, 2026

Copy link
Copy Markdown
Member

Rationale for this change

I met unused warning at compilation

[~/arrow-rs-object-store] (main) 
vscode@bf21a2fa9d74$ cargo test --lib in_memory_test
   Compiling object_store v0.13.2 (/home/vscode/arrow-rs-object-store)
warning: unused macro definition: `maybe_skip_integration`
    --> src/lib.rs:2157:18
     |
2157 |     macro_rules! maybe_skip_integration {
     |                  ^^^^^^^^^^^^^^^^^^^^^^
     |
     = note: `#[warn(unused_macros)]` on by default

warning: unused import: `maybe_skip_integration`
    --> src/lib.rs:2165:20
     |
2165 |     pub(crate) use maybe_skip_integration;
     |                    ^^^^^^^^^^^^^^^^^^^^^^
     |
     = note: `#[warn(unused_imports)]` on by default

What changes are included in this PR?

This PR removes unused macro, which is complaint by compiler.

Are there any user-facing changes?

No

@crepererum

Copy link
Copy Markdown
Contributor

I think the code IS used, e.g. here:

maybe_skip_integration!();

@dentiny

dentiny commented Apr 8, 2026

Copy link
Copy Markdown
Member Author

I think the code IS used, e.g. here:

I must get fooled by the warning message! Sorry for the spam, shame on my

@dentiny dentiny closed this Apr 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants