Skip to content

fix(aws): populate default header for complete multipart request#688

Merged
crepererum merged 3 commits into
apache:mainfrom
dentiny:hjiang/populate-header-complete-multipart
May 6, 2026
Merged

fix(aws): populate default header for complete multipart request#688
crepererum merged 3 commits into
apache:mainfrom
dentiny:hjiang/populate-header-complete-multipart

Conversation

@dentiny

@dentiny dentiny commented Apr 9, 2026

Copy link
Copy Markdown
Member

Rationale for this change

Hi team, when reading the code, I found CompleteMultipart doesn't populate the default headers

let request = self
.client
.post(url)
.query(&[("uploadId", upload_id)])
.body(body)
.with_aws_sigv4(credential.authorizer(), None);

While headers are added for other counterpart operations
PUT:

let mut builder = self.client.request(Method::POST, url);
if let Some(headers) = self.config.client_options.get_default_headers() {
builder = builder.headers(headers.clone());
}

GET:
let mut builder = self.client.request(method, url);
if let Some(headers) = self.config.client_options.get_default_headers() {
builder = builder.headers(headers.clone());
}

What changes are included in this PR?

This PR populate headers to complete multipart upload HTTP request.

Are there any user-facing changes?

No.

@crepererum crepererum left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@crepererum
crepererum merged commit 1a0d21e into apache:main May 6, 2026
9 checks passed
@alamb alamb changed the title fix(aws): populate default header for complete mutipart request fix(aws): populate default header for complete multipart request Jun 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants