You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Disclaimer: this issues was discovered by opus when I was leverage LLM to read through the code.
This PR adds missing extension through BufWriter single put shutdown path.
Reading through the codebase, it reads to me "attributes", "tags" and "extensions" should all be assigned for PutOptions.
error: explicit call to .into_iter() in function argument accepting IntoIterator
--> src/client/list.rs:120:36
|
120 | common_prefixes.extend(response.common_prefixes.into_iter());
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
note: this parameter accepts any IntoIterator, so you don't need to call .into_iter()
Hi @crepererum , sorry for the interruption and thanks for the previous reviews, I'm wondering if you mind taking another look maybe when you have some time? Thank you so much!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Disclaimer: this issues was discovered by opus when I was leverage LLM to read through the code.
This PR adds missing extension through BufWriter single put shutdown path.
Reading through the codebase, it reads to me "attributes", "tags" and "extensions" should all be assigned for
PutOptions.Another example for multipart upload options
arrow-rs-object-store/src/buffered.rs
Lines 341 to 344 in e89f62b
What changes are included in this PR?
This PR passes the missing
extensionfield toPutOption.Are there any user-facing changes?
No