fix(core): add missing version assignment#691
Merged
Conversation
crepererum
reviewed
Apr 15, 2026
Contributor
|
I wonder if we could have a regression test for this? 🤔 |
Member
Author
I didn't do that initially since it's an easy change, your code suggestion already prevents bugs for future field changes. And unit tests themselves are maintenance overhead. But let me think about it. |
Member
Author
|
Hi @crepererum , sorry for the interruption and thanks for the previous reviews, I'm wondering if you mind taking another look maybe when you have some time? Thank you so much! |
crepererum
reviewed
May 6, 2026
Member
Author
Thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are included in this PR?
This PR adds missing
versionfield assignment forObjectMetadata.Are there any user-facing changes?
No.