GCP: fix copy (no) overwrite semantics#713
Merged
Merged
Conversation
Contributor
Author
|
Note: I believe the GCS emulator used in tests does not support object versioning, so I didn't try to add a test here. Up to reviewers judgement though. |
james-rms
force-pushed
the
jrms/fix-gcp-copy-no-overwrite
branch
from
May 7, 2026 11:50
831f3cf to
ef6deac
Compare
Contributor
Author
|
@tustvold @crepererum sorry to bother - this feels reasonably high-impact to me as well as very simple to review. Are either of you available to take a look? |
tustvold
approved these changes
May 20, 2026
tustvold
left a comment
tustvold
left a comment
Contributor
There was a problem hiding this comment.
Makes sense to me, thank you
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #712
Rationale for this change
On
main,GoogleCloudStorage::copy(src, dst)fails withError::AlreadyExistsifdstis the path to an existing object. This is the wrong default behavior - CopyMode defaults to Overwrite, not Create. This happens because of a bug inGoogleCloudStorage::copy_opts, where CopyMode::Overwrite gets mapped toif_not_exists = trueinstead offalse.What changes are included in this PR?
This PR fixes and moves the boolean mapping closest to where it gets used, to minimise confusion.
Are there any user-facing changes?
Yes. Anyone using GoogleCloudStorage::copy today who is relying on the incorrect behavior will see objects getting overwritten instead of an error.