Fix flaky local close-file tests#757
Merged
alamb merged 1 commit intoJun 17, 2026
Merged
Conversation
alamb
approved these changes
Jun 17, 2026
alamb
left a comment
alamb
left a comment
Contributor
There was a problem hiding this comment.
looks good to me -- thank you @kevinjqliu
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
The close-file error tests tried to force an error by closing a temp file, rebuilding a
Filefrom the now-invalid fd/handle, and closing it again. In parallel test runs, that fd/handle value can be reused by another test, causing the close test to unexpectedly succeed or close another test's resource.This makes CI flaky and has affected two PRs recently:
What changes are included in this PR?
This adds small Unix and Windows helpers for closing raw fd/handle values, and keeps
close_file(File)delegating to those helpers.The close-file error tests now assert the expected invalid fd/handle errors directly, instead of reconstructing a
Filefrom a closed resource.Are there any user-facing changes?
No. This only changes internal test coverage for local filesystem close-error handling.