Clarify aws-lc-rs feature docs and fix CI comment URL#764
Merged
Conversation
Follow-on documentation polish from the review of apache#707. - Document that the `aws-lc-rs` feature requires the user to also select an aws-lc-rs backend when the built-in `reqwest` transport is not enabled. - Fix the malformed github.com URL in the CI testing-matrix comment. Comment/documentation-only; no code or behavior changes. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Tpt
approved these changes
Jun 17, 2026
kevinjqliu
reviewed
Jun 17, 2026
Co-authored-by: Kevin Liu <kevinjqliu@users.noreply.github.com>
Contributor
Author
|
Thanks again @kevinjqliu |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Follow-on documentation polish from
Rationale for this change
While reviewing #707 (Pluggable Crypto / reqwest 0.13) after merge, claude found 2 doc issues:
object_store'saws-lc-rsfeature deliberately does not select anaws-lc-rsbackend (aws-lc-sys/fips/non-fips), so that downstream crates retain control over that choice. As a result, enablingaws-lc-rstogether with a*-basefeature but without the built-inreqwesttransport fails to compile until the user selects a backend. This was non-obvious and not documented.ci.ymlhad a broken issue link (https://githubcom/..., missing the.).What changes are included in this PR?
Are there any user-facing changes?
Documentation only — clarifies an existing feature-flag requirement. No API or behavior changes, and nothing breaking.