digest and hmac: drop intermediate builder and directly take slices for input#766
Open
Tpt wants to merge 2 commits into
Open
digest and hmac: drop intermediate builder and directly take slices for input#766Tpt wants to merge 2 commits into
Tpt wants to merge 2 commits into
Conversation
…or input It removes the need for intermediate traits. All callers can easily build a slice of slices but the S3 object content SHA 256 computation that is expensive anyway.
kevinjqliu
reviewed
Jun 18, 2026
Co-authored-by: Kevin Liu <kevinjqliu@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It removes the need for intermediate traits.
All callers can easily build a slice of slices but the S3 object content SHA 256 computation that is expensive anyway.
Follow up to #707