Skip to content

Commit 3ed4721

Browse files
alambclaude
andauthored
test(arrow-select): add take_bytes coverage for sliced values and nullable offset overflow (#10053)
# Which issue does this PR close? - test-only follow-up to #9625. # Rationale for this change While reviewing #9625 (which rewrites `take_bytes`), I noticed two paths in the existing test suite were not directly exercised: 1. **Taking from a *sliced* byte array** 2. **The `OffsetOverflowError` on the nullable path** — `test_take_bytes_offset_overflow` only uses non-null indices, so it only covers the no-null fast path. I can write tests which pass against `main` today and show the existing behavior give #9625 (and future `take_bytes` changes) better coverage of the byte-copy and overflow paths. # What changes are included in this PR? Two new tests in `arrow-select/src/take.rs`: # Are these changes tested? These changes *are* tests. They pass on the current implementation. # Are there any user-facing changes? None. --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 parent a815910 commit 3ed4721

0 file changed

File tree

    0 commit comments

    Comments
     (0)