fix(cast): Trying to fix cast losting schema problem#10005
Merged
Conversation
mapleFU
force-pushed
the
trying-to-fix-cast-lost-schema
branch
from
6cb0888 to
b3c3ba3
Compare
mapleFU
requested review from
Jefffrey and
alamb
and removed request for
Jefffrey
alamb
approved these changes
May 21, 2026
| for target_type in &target_types { | ||
| let result = cast(&src, target_type).unwrap(); | ||
| assert_eq!( | ||
| result.data_type(), |
Contributor
There was a problem hiding this comment.
I verified this test covers the change by removing the code change and running the test (it fails like this):
thread 'cast::tests::test_cast_fixed_size_list_to_list_preserves_field_metadata' (76333843) panicked at arrow-cast/src/cast/mod.rs:9068:13:
assertion `left == right` failed: Cast to List(Field { name: "element", data_type: Float32, nullable: true, metadata: {"PARQUET:field_id": "89"} }) should preserve field metadata
left: List(Field { data_type: Float32, nullable: true })
right: List(Field { name: "element", data_type: Float32, nullable: true, metadata: {"PARQUET:field_id": "89"} })
failures:
cast::tests::test_cast_fixed_size_list_to_list_preserves_field_metadata
test result: FAILED. 341 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.02s
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Previously, just
data_typeis considered. Now the field is taking into account.What changes are included in this PR?
Previously, just
data_typeis considered. Now the field is taking into account.Are these changes tested?
Yes
Are there any user-facing changes?
Maybe cast would be a bit more strict