Fix merge_kernels benchmark panic due to not wrapping with Scalar#10199
Merged
Conversation
5 tasks
alamb
approved these changes
Jun 23, 2026
| &mut group, | ||
| &masks, | ||
| &non_null_scalar_1, | ||
| &Scalar::new(non_null_scalar_1.clone()), |
Contributor
There was a problem hiding this comment.
I verified this panic on main with
cargo bench --bench merge_kernels --profile=dev -- non_null_scalar_vs_array
...
Benchmarking merge_8192_from_i32/non_null_scalar_vs_array/all_true: Warming up for 3.0000 s
thread 'main' (115763431) panicked at arrow-data/src/transform/primitive.rs:31:43:
range end index 8192 out of range for slice of length 1
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
error: bench failed, to rerun pass `-p arrow --bench merge_kernels`| &masks, | ||
| &array_1_10pct_nulls, | ||
| &non_null_scalar_1, | ||
| &Scalar::new(non_null_scalar_1.clone()), |
Contributor
There was a problem hiding this comment.
I verified this panic on main with
cargo bench --bench merge_kernels --profile=dev -- array_vs_non_null_scalar
...
Benchmarking merge_8192_from_i32/array_vs_non_null_scalar/99pct_true: Warming up for 3.0000 s
thread 'main' (115764966) panicked at arrow-data/src/transform/primitive.rs:31:43:
range end index 2 out of range for slice of length 1
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
error: bench failed, to rerun pass `-p arrow --bench merge_kernels`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as identified by
this benchmark was panicking when run, because it was passing a 1-len array as an
ArrayRefinstead of aScalarand thus indexing the 2nd/3rd element was causing out of bounds panic; when wrapped inScalarthe single element will be repeated so it wouldn't index out of bounds it would just get the first element