chore: deduplicate filter nulls code in coalesce/filter kernel#10348
Open
Jefffrey wants to merge 1 commit into
Open
chore: deduplicate filter nulls code in coalesce/filter kernel#10348Jefffrey wants to merge 1 commit into
Jefffrey wants to merge 1 commit into
Conversation
Jefffrey
commented
Jul 15, 2026
| let nulls = unsafe { | ||
| NullBuffer::new_unchecked(BooleanBuffer::new(nulls, 0, filter.count()), null_count) | ||
| }; | ||
| self.nulls.append_buffer(&nulls); |
Contributor
Author
There was a problem hiding this comment.
since filter_nulls() already creates the nullbuffer for us, just use that
arrow-rs/arrow-select/src/filter.rs
Lines 490 to 517 in a4ac705
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
whilst reviewing #10236 i noticed we have a little code duplication, so remedying that