refactor(arrow-avro): use Decoder::flush_block in async reader#9726
Merged
alamb merged 1 commit intoapache:mainfrom Apr 22, 2026
Merged
refactor(arrow-avro): use Decoder::flush_block in async reader#9726alamb merged 1 commit intoapache:mainfrom
Decoder::flush_block in async reader#9726alamb merged 1 commit intoapache:mainfrom
Conversation
In arrow-avro. Since the async reader only reads OCF files and uses decode_block to decode, use flush_block for consistency and to avoid unnecessary checks.
github-actions
Bot
added
arrow
Contributor
|
What problem is this PR solving? I am not super familiar with the code |
Contributor
Author
|
It's just a minor cleanup that I did initially while working on #9611, but one of the reviewers flagged that it should be submitted separately. Perhaps I shouldn't have bothered to split it out. |
alamb
approved these changes
Apr 22, 2026
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Looks good to me
Thank you @mzabaluev
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the async reader only reads OCF files and uses
Decoder::decode_blockto decode, useflush_blockfor consistency and to avoid an unnecessary check for mid-content schema changes.Are these changes tested?
No new behavior is introduced, the existing tests should pass.
Are there any user-facing changes?
No