feat: add VariantArrayBuilder::with_shredding#9963
Open
Shekharrajak wants to merge 1 commit into
Open
Conversation
afac072 to
f52d0c9
Compare
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref #8480
Rationale for this change
Adds a builder method that configures VariantArrayBuilder to produce a shredded VariantArray at build() time.
What changes are included in this PR?
Add shredding_schema: Option field to VariantArrayBuilder
Add with_shredding(as_type: DataType) -> Self — rows are still appended unshredded via append_variant; the shredding pass runs once at build() by delegating to shred_variant
Are these changes tested?
unit tests
Are there any user-facing changes?
Yes, usage: