Skip to content

Commit 6cefbd3

Browse files
thisisnicjonkeane
andauthored
GH-49654: [R][CI] Add check for non-API calls onto existing r-devel job (#49655)
### Rationale for this change I wanna know when we get NOTEs about this so we don't need to wait til CRAN pings us ### What changes are included in this PR? Add check to r-devel jobs ### Are these changes tested? Those CI jobs should fail now ### Are there any user-facing changes? Nah * GitHub Issue: #49654 Lead-authored-by: Nic Crane <thisisnic@gmail.com> Co-authored-by: Jonathan Keane <jkeane@gmail.com> Signed-off-by: Nic Crane <thisisnic@gmail.com>
1 parent 5fd30d3 commit 6cefbd3

1 file changed

Lines changed: 13 additions & 1 deletion

File tree

dev/tasks/r/github.linux.cran.yml

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,13 +48,25 @@ jobs:
4848
env:
4949
{{ macros.github_set_sccache_envvars()|indent(8)}}
5050
# setting ARROW_SOURCE_HOME='' here ensures that we use the cpp source copied into tools/
51-
run: archery docker run -e ARROW_SOURCE_HOME='' -e SKIP_VIGNETTES={{ '${{ matrix.config.skip_vignettes }}' }} r
51+
run: >
52+
archery docker run
53+
-e ARROW_SOURCE_HOME=''
54+
-e SKIP_VIGNETTES={{ '${{ matrix.config.skip_vignettes }}' }}
55+
-e _R_CHECK_CRAN_INCOMING_=false
56+
r
5257
- name: Dump install logs
5358
run: cat arrow/r/check/arrow.Rcheck/00install.out
5459
if: always()
5560
- name: Dump test logs
5661
run: cat arrow/r/check/arrow.Rcheck/tests/testthat.Rout*
5762
if: always()
63+
- name: Check for R CMD check NOTES
64+
run: |
65+
if grep -q "^.* checking .* \\.\\.\\. NOTE$" arrow/r/check/arrow.Rcheck/00check.log; then
66+
echo "Found R CMD check NOTE(s) in output:"
67+
grep -n -A8 "^.* checking .* \\.\\.\\. NOTE$" arrow/r/check/arrow.Rcheck/00check.log
68+
exit 1
69+
fi
5870
- name: Save the test output
5971
if: always()
6072
uses: actions/upload-artifact@v4

0 commit comments

Comments
 (0)