Initial commit

Author: tadeja

cpp/src/arrow/ipc/feather.cc

@@ -770,7 +770,9 @@ class ReaderV2 : public Reader {
 
 Result<std::shared_ptr<Reader>> Reader::Open(
     const std::shared_ptr<io::RandomAccessFile>& source) {
+  ARROW_SUPPRESS_DEPRECATION_WARNING
   return Reader::Open(source, IpcReadOptions::Defaults());
+  ARROW_UNSUPPRESS_DEPRECATION_WARNING
 }
 
 Result<std::shared_ptr<Reader>> Reader::Open(

cpp/src/arrow/ipc/feather.h

@@ -28,6 +28,7 @@
 #include "arrow/ipc/options.h"
 #include "arrow/type_fwd.h"
 #include "arrow/util/compression.h"
+#include "arrow/util/macros.h"
 #include "arrow/util/visibility.h"
 
 namespace arrow {
@@ -54,6 +55,9 @@ static constexpr const int kFeatherV2Version = 3;
 
 /// \class Reader
 /// \brief An interface for reading columns from Feather files
+///
+/// \note Deprecated in 25.0.0. Feather V2 is the Arrow IPC file format;
+///   use arrow::ipc::RecordBatchFileReader instead.
 class ARROW_EXPORT Reader {
  public:
   virtual ~Reader() = default;
@@ -62,6 +66,9 @@ class ARROW_EXPORT Reader {
   ///
   /// \param[in] source a RandomAccessFile instance
   /// \return the table reader
+  /// \deprecated Deprecated in 25.0.0. Use arrow::ipc::RecordBatchFileReader instead.
+  ARROW_DEPRECATED(
+      "Deprecated in 25.0.0. Use arrow::ipc::RecordBatchFileReader instead.")
   static Result<std::shared_ptr<Reader>> Open(
       const std::shared_ptr<io::RandomAccessFile>& source);
 
@@ -71,6 +78,9 @@ class ARROW_EXPORT Reader {
   /// \param[in] source a RandomAccessFile instance
   /// \param[in] options IPC Read options
   /// \return the table reader
+  /// \deprecated Deprecated in 25.0.0. Use arrow::ipc::RecordBatchFileReader instead.
+  ARROW_DEPRECATED(
+      "Deprecated in 25.0.0. Use arrow::ipc::RecordBatchFileReader instead.")
   static Result<std::shared_ptr<Reader>> Open(
       const std::shared_ptr<io::RandomAccessFile>& source, const IpcReadOptions& options);
 
@@ -107,6 +117,11 @@ class ARROW_EXPORT Reader {
                       std::shared_ptr<Table>* out) = 0;
 };
 
+/// \struct WriteProperties
+/// \brief Options for writing Feather files
+///
+/// \note Deprecated in 25.0.0. Feather V2 is the Arrow IPC file format;
+///   use arrow::ipc::MakeFileWriter with arrow::ipc::IpcWriteOptions instead.
 struct ARROW_EXPORT WriteProperties {
   static WriteProperties Defaults();
 
@@ -141,6 +156,11 @@ struct ARROW_EXPORT WriteProperties {
   int compression_level = ::arrow::util::kUseDefaultCompressionLevel;
 };
 
+/// \brief Write a Table to a Feather file
+///
+/// \deprecated Deprecated in 25.0.0. Feather V2 is the Arrow IPC file format;
+///   use arrow::ipc::MakeFileWriter instead.
+ARROW_DEPRECATED("Deprecated in 25.0.0. Use arrow::ipc::MakeFileWriter instead.")
 ARROW_EXPORT
 Status WriteTable(const Table& table, io::OutputStream* dst,
                   const WriteProperties& properties = WriteProperties::Defaults());

cpp/src/arrow/ipc/feather_test.cc

@@ -44,6 +44,10 @@ using internal::checked_cast;
 namespace ipc {
 namespace feather {
 
+// These tests intentionally exercise the deprecated Feather API, supressing
+// the deprecation warnings for the whole file.
+ARROW_SUPPRESS_DEPRECATION_WARNING
+
 struct TestParam {
   TestParam(int arg_version,
             Compression::type arg_compression = Compression::UNCOMPRESSED)
@@ -383,6 +387,8 @@ TEST_P(TestFeatherRoundTrip, RoundTrip) {
 INSTANTIATE_TEST_SUITE_P(FeatherRoundTripTests, TestFeatherRoundTrip,
                          ::testing::ValuesIn(kBatchCases));
 
+ARROW_UNSUPPRESS_DEPRECATION_WARNING
+
 }  // namespace feather
 }  // namespace ipc
 }  // namespace arrow

python/pyarrow/includes/libarrow_feather.pxd

@@ -23,6 +23,8 @@ from pyarrow.includes.libarrow cimport (CCompressionType, CStatus, CTable,
                                         c_string, CIpcReadOptions)
 
 
+# NOTE: these feather C++ APIs are deprecated. Pyarrow still binds them,
+# the user-facing FutureWarning lives in pyarrow/feather.py (GH-49232).
 cdef extern from "arrow/ipc/api.h" namespace "arrow::ipc" nogil:
     int kFeatherV1Version" arrow::ipc::feather::kFeatherV1Version"
     int kFeatherV2Version" arrow::ipc::feather::kFeatherV2Version"

r/src/feather.cpp

@@ -36,7 +36,9 @@ void ipc___WriteFeather__Table(const std::shared_ptr<arrow::io::OutputStream>& s
   if (compression_level != -1) {
     properties.compression_level = compression_level;
   }
+  ARROW_SUPPRESS_DEPRECATION_WARNING
   StopIfNotOk(arrow::ipc::feather::WriteTable(*table, stream.get(), properties));
+  ARROW_UNSUPPRESS_DEPRECATION_WARNING
 }
 
 // ----------- Reader
@@ -83,7 +85,11 @@ std::shared_ptr<arrow::Table> ipc___feather___Reader__Read(
 std::shared_ptr<arrow::ipc::feather::Reader> ipc___feather___Reader__Open(
     const std::shared_ptr<arrow::io::RandomAccessFile>& stream) {
   auto result = RunWithCapturedRIfPossible<std::shared_ptr<arrow::ipc::feather::Reader>>(
-      [&]() { return arrow::ipc::feather::Reader::Open(stream); });
+      [&]() {
+        ARROW_SUPPRESS_DEPRECATION_WARNING
+        return arrow::ipc::feather::Reader::Open(stream);
+        ARROW_UNSUPPRESS_DEPRECATION_WARNING
+      });
   return ValueOrStop(result);
 }