Skip to content

GH-38217: [R] Map format = "text to format = "csv" in write_dataset() #50367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
thisisnic wants to merge 1 commit into
base: main
Choose a base branch
from
+24 −6
Draft

GH-38217: [R] Map format = "text to format = "csv" in write_dataset() #50367

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion r/R/dataset-write.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,9 @@ write_dataset <- function(
if (format %in% c("feather", "ipc")) {
format <- "arrow"
}
if (format == "text") {
format <- "csv"
}
if (inherits(dataset, "arrow_dplyr_query")) {
# partitioning vars need to be in the `select` schema
dataset <- ensure_group_vars(dataset)
Expand Down Expand Up @@ -189,7 +192,7 @@ write_dataset <- function(
path_and_fs <- get_path_and_filesystem(path)

dots <- list(...)
if (format %in% c("txt", "text") && !any(c("delimiter", "delim") %in% names(dots))) {
if (format == "txt" && !any(c("delimiter", "delim") %in% names(dots))) {
stop("A delimiter must be given for a txt format.")
}
if (format == "tsv" && any(c("delimiter", "delim") %in% names(dots))) {
Expand Down
25 changes: 20 additions & 5 deletions r/tests/testthat/test-dataset-write.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -913,11 +913,6 @@ test_that("Writing a flat file dataset without a delimiter throws an error.", {
write_dataset(df, dst_dir, format = "txt"),
"A delimiter must be given for a txt format."
)

expect_error(
write_dataset(df, dst_dir, format = "text"),
"A delimiter must be given for a txt format."
)
})

test_that("Dataset can write flat files using readr::write_csv() options.", {
Expand Down Expand Up @@ -1048,3 +1043,23 @@ test_that("Row order is preserved when writing large parquet dataset", {
# But ordered is exactly equal.
expect_equal(ordered_ds$x, df$x)
})

test_that("write_dataset maps format 'text' to 'csv' (GH-38217)", {
df <- tibble(
int = 1:10,
dbl = as.numeric(1:10),
chr = letters[1:10],
)

dst_dir <- make_temp_dir()
write_dataset(df, dst_dir, format = "text")
expect_true(dir.exists(dst_dir))

# Files should have .csv extension, not .text
written_files <- list.files(dst_dir)
expect_match(written_files, "\\.csv$")

# Data should round-trip correctly
result <- open_dataset(dst_dir, format = "csv") |> collect()
expect_equal(result, df)
})
Loading