From 1a79177d7714e10e4bc65019873c77d9e6aea554 Mon Sep 17 00:00:00 2001 From: Anas Khan <83116240+anxkhn@users.noreply.github.com> Date: Fri, 3 Jul 2026 14:10:13 +0530 Subject: [PATCH] test(python): assert assume_timezone nonexistent/ambiguous results Four comparisons in test_assume_timezone computed a result with .equals() but dropped the assert, so the boolean was discarded and nothing was verified. As a result the assume_timezone kernel's DST nonexistent (shift_forward/shift_backward) and ambiguous (earliest/latest) output branches were exercised but never checked, letting a regression pass. Prefix the four bare comparisons with assert, matching the assert result.equals(pa.array(expected)) form already used earlier in the same test. --- python/pyarrow/tests/test_compute.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/python/pyarrow/tests/test_compute.py b/python/pyarrow/tests/test_compute.py index 39167e76c8f..897cd7500df 100644 --- a/python/pyarrow/tests/test_compute.py +++ b/python/pyarrow/tests/test_compute.py @@ -2809,13 +2809,13 @@ def test_assume_timezone(): timezone, nonexistent="shift_forward")) result = pc.assume_timezone( nonexistent_array, options=options_nonexistent_latest) - expected.equals(result) + assert expected.equals(result) expected = pa.array(nonexistent.tz_localize( timezone, nonexistent="shift_backward")) result = pc.assume_timezone( nonexistent_array, options=options_nonexistent_earliest) - expected.equals(result) + assert expected.equals(result) options_ambiguous_raise = pc.AssumeTimezoneOptions(timezone) options_ambiguous_latest = pc.AssumeTimezoneOptions( @@ -2831,12 +2831,12 @@ def test_assume_timezone(): expected = ambiguous.tz_localize(timezone, ambiguous=[True, True, True]) result = pc.assume_timezone( ambiguous_array, options=options_ambiguous_earliest) - result.equals(pa.array(expected)) + assert result.equals(pa.array(expected)) expected = ambiguous.tz_localize(timezone, ambiguous=[False, False, False]) result = pc.assume_timezone( ambiguous_array, options=options_ambiguous_latest) - result.equals(pa.array(expected)) + assert result.equals(pa.array(expected)) def _check_temporal_rounding(ts, values, unit):