ARTEMIS-5974 replace FactoryFinder with Java ServiceLoader#6324
Merged
tabish121 merged 1 commit intoapache:mainfrom Apr 8, 2026
Merged
ARTEMIS-5974 replace FactoryFinder with Java ServiceLoader#6324tabish121 merged 1 commit intoapache:mainfrom
tabish121 merged 1 commit intoapache:mainfrom
Conversation
tabish121
reviewed
Apr 1, 2026
| @@ -0,0 +1 @@ | |||
| org.apache.activemq.artemis.cli.factory.xml.XmlBrokerFactoryHandler | |||
Contributor
There was a problem hiding this comment.
It seems like these service definitions can still have Apache license headers added as the ServiceLoader javadocs indicates it will ignore anything following the '#' character
Contributor
Author
There was a problem hiding this comment.
I have no problem adding the license header, but it's worth noting that we've specifically configured apache-rat-plugin in the root pom.xml to exclude **/META-INF/services/* which means we have a lot of other service files without headers (and have for years).
Contributor
Author
There was a problem hiding this comment.
FYI - I sent #6352 to deal with all the other service provider config files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.