Skip to content

ARTEMIS-6037 refactor handling of cluster credentials#6396

Merged
clebertsuconic merged 1 commit intoapache:mainfrom
jbertram:ARTEMIS-6037
May 1, 2026
Merged

ARTEMIS-6037 refactor handling of cluster credentials#6396
clebertsuconic merged 1 commit intoapache:mainfrom
jbertram:ARTEMIS-6037

Conversation

@jbertram
Copy link
Copy Markdown
Contributor

@jbertram jbertram commented Apr 28, 2026

No description provided.

@jbertram
Copy link
Copy Markdown
Contributor Author

jbertram commented Apr 28, 2026

The test-suite looks good on this. I'll send another PR to update the examples repo.

@jbertram jbertram force-pushed the ARTEMIS-6037 branch 2 times, most recently from 8ddc147 to a55e06d Compare April 29, 2026 13:54
@tabish121
Copy link
Copy Markdown
Contributor

tabish121 commented Apr 29, 2026 •
edited
Loading

Running in CI I see repeated failures in the follow tests that don't appear in other runs not on this branch

[Run / Test / 2 / org.apache.activemq.artemis.tests.integration.cluster.topology.HAClientTopologyTest.testWrongPasswordTriggersClusterConnectionStop]
    [Run / Test / 0 / org.apache.activemq.artemis.tests.integration.cluster.topology.NettyHAClientTopologyWithDiscoveryTest.testWrongPasswordTriggersClusterConnectionStop]Run___Test___0___testWrongPasswordTriggersClusterConnectionStop/)
    [Run / Test / 4 / org.apache.activemq.artemis.tests.integration.cluster.topology.HAClientTopologyWithDiscoveryTest.testWrongPasswordTriggersClusterConnectionStop]

@jbertram jbertram marked this pull request as draft April 29, 2026 18:34
@jbertram jbertram force-pushed the ARTEMIS-6037 branch 2 times, most recently from 33f0cf4 to 48450f9 Compare April 30, 2026 00:12
@jbertram
Copy link
Copy Markdown
Contributor Author

jbertram commented Apr 30, 2026

I dealt with the test failures and also made some changes in org.apache.activemq.artemis.core.server.cluster, added a couple tests for those changes, and ran the test-suite again which looks good.

@jbertram jbertram marked this pull request as ready for review April 30, 2026 01:22
@jbertram jbertram mentioned this pull request Apr 30, 2026
Merged
clebertsuconic
clebertsuconic reviewed Apr 30, 2026
View reviewed changes
Comment thread ...s-server/src/main/java/org/apache/activemq/artemis/core/security/impl/SecurityStoreImpl.java Outdated

private ClusterCredentialsCheckResult checkClusterCredentials(String user, String password) {
if ((getDefaultClusterUser().equals(user) && getDefaultClusterPassword().equals(password)) ||
(managementClusterUser.equals(user) && !managementClusterPassword.equals(password))) {
Copy link
Copy Markdown
Contributor

@clebertsuconic clebertsuconic Apr 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would make this a separate branch on the if... I think it would be clearer

@jbertram jbertram force-pushed the ARTEMIS-6037 branch 2 times, most recently from 5185512 to 108381c Compare May 1, 2026 19:20
@clebertsuconic clebertsuconic merged commit 9054a60 into apache:main May 1, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@clebertsuconic clebertsuconic clebertsuconic left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jbertram @tabish121 @clebertsuconic