Skip to content

AVRO-4239: fix Perl porting's lack of version number#3704

Merged
martin-g merged 1 commit intoapache:branch-1.12from
alivraghi:AVRO-4239
Apr 15, 2026
Merged

AVRO-4239: fix Perl porting's lack of version number#3704
martin-g merged 1 commit intoapache:branch-1.12from
alivraghi:AVRO-4239

Conversation

@alivraghi
Copy link
Copy Markdown
Contributor

What is the purpose of the change

Starting with v1.11.4, the Perl porting fails to dinamically set the $VERSION variable when installing from CPAN or from .tar.gz.

Verifying this change

Reviewed the dist build process to make available VERSION.txt file in the .tar.gz dist.

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

@martin-g
Copy link
Copy Markdown
Member

martin-g commented Apr 7, 2026

@RyanSkraba This seems to be needed for 1.12.next

@opwvhk
Copy link
Copy Markdown
Contributor

opwvhk commented Apr 13, 2026

Is this also needed for 1.13?

To me this change looks like a way to make VERSION.txt available for the Perl module after distribution. If my guess is correct, I think we'll want apply this change to main as well.

@alivraghi
Copy link
Copy Markdown
Contributor Author

Is this also needed for 1.13?

To me this change looks like a way to make VERSION.txt available for the Perl module after distribution. If my guess is correct, I think we'll want apply this change to main as well.

Yes; the goal is to ensure VERSION.txt is available for the Perl module within the distribution file.

This adjustment needs to be applied to both the 1.12 and 1.13 branches, as well as the main branch. Please let me know if you would like me to submit a separate pull request for the 1.13 branch.

@martin-g martin-g merged commit 846a201 into apache:branch-1.12 Apr 15, 2026
1 check passed
martin-g pushed a commit that referenced this pull request Apr 15, 2026
Co-authored-by: Alvaro Livraghi <a.livraghi@sirti.it>
(cherry picked from commit 846a201)
@martin-g
Copy link
Copy Markdown
Member

Cherry-picked it to main with 33b104f

@martin-g
Copy link
Copy Markdown
Member

Thank you, @alivraghi !

@alivraghi
Copy link
Copy Markdown
Contributor Author

Happy to contribute!
Thanks everyone for keeping this project awesome. 👍

@alivraghi alivraghi deleted the AVRO-4239 branch April 15, 2026 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants